Date: Tue, 15 Sep 2020 14:18:04 +0300 From: Vitaly Chikunov Subject: Re: [PATCH] libs: Add linking dependencies to libcopperplate and libsmokey Message-ID: <20200915111804.7kriz5kl7kozawjk@altlinux.org> References: <20200914215233.10877-1-vt@altlinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: List-Id: Discussions about the Xenomai project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xenomai Cc: "Dmitry V. Levin" Jan, On Tue, Sep 15, 2020 at 12:38:55PM +0200, Jan Kiszka wrote: > On 14.09.20 23:52, Vitaly Chikunov wrote: > > ALT rpmbuild QA script detects that libsmokey and libcopperplate is improperly > > linked (when built for Mercury core). > > > > Excerpt from the error message: > > verify-elf: ERROR: ./usr/lib64/libsmokey.so.0.0.0: undefined symbol: get_mem_size > > verify-elf: ERROR: ./usr/lib64/libcopperplate.so.0.0.0: undefined symbol: get_mem_size > > > > Could such a test be added to our regular build, or is it depending on rpm > or altlinux? It's tightly integrated into our rpmbuild system so it would be not easy to make it independent. But, I will think about it. > > > Signed-off-by: Vitaly Chikunov > > --- > > lib/copperplate/Makefile.am | 3 ++- > > lib/smokey/Makefile.am | 1 + > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/lib/copperplate/Makefile.am b/lib/copperplate/Makefile.am > > index f832d1c89..c7104eb02 100644 > > --- a/lib/copperplate/Makefile.am > > +++ b/lib/copperplate/Makefile.am > > @@ -2,7 +2,8 @@ > > lib_LTLIBRARIES = libcopperplate.la > > libcopperplate_la_LDFLAGS = @XENO_LIB_LDFLAGS@ -lpthread -lrt -version-info 0:0:0 > > -libcopperplate_la_LIBADD = > > +libcopperplate_la_LIBADD = @XENO_CORE_LDADD@ > > + > > noinst_LTLIBRARIES = > > libcopperplate_la_SOURCES = \ > > diff --git a/lib/smokey/Makefile.am b/lib/smokey/Makefile.am > > index 53c775c68..4ecae1f16 100644 > > --- a/lib/smokey/Makefile.am > > +++ b/lib/smokey/Makefile.am > > @@ -1,6 +1,7 @@ > > lib_LTLIBRARIES = libsmokey.la > > libsmokey_la_LDFLAGS = @XENO_LIB_LDFLAGS@ -version-info 0:0:0 > > +libsmokey_la_LIBADD = @XENO_CORE_LDADD@ > > libsmokey_la_SOURCES = \ > > helpers.c \ > > > > Thanks, applied to next. Thanks! > > Jan > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux