Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5825AC2D0E3 for ; Wed, 16 Sep 2020 00:12:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D2D220739 for ; Wed, 16 Sep 2020 00:12:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600215124; bh=scyhgd3VmsafSl7Zt98dhk+r7cWGfTn6eGr16ow1X9w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=TBYm9QeUekF4Bm2V9lt5glyIbCaDQKw7tIAsxEPIYLtyYCbZYX/xdHyatbt9pTv/8 D7thY8ANeNHG0jC36yzRZd9pvsps62VhcSg1BUxMhve3Rnc5ZWVduvEP6KdAyVDvf1 MtS06vs1E+q3PE0WqgxTBII+HkaLNc0Vu9He4z6c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727150AbgIPAMC (ORCPT ); Tue, 15 Sep 2020 20:12:02 -0400 Received: from forward4-smtp.messagingengine.com ([66.111.4.238]:36407 "EHLO forward4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726847AbgIOO0a (ORCPT ); Tue, 15 Sep 2020 10:26:30 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailforward.nyi.internal (Postfix) with ESMTP id 1FE201940B9D; Tue, 15 Sep 2020 10:01:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 15 Sep 2020 10:01:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=Tj1t3x ABHZjsC2NjqJwZYpMhXu3dpb7qewiHFHSRUdc=; b=J0GR7UMVLfoLYUWKI+xxmz fCPrr0ZNYS9aVHuzp7DoFy2XsMNfiBoD8RNdWPVQQu5rl+DelMBPZQsLrNsHvUq4 yu8nzbWi7qGAakcgJeHSwEhFHIhfgEy8x0BGCNAtQP+Aoe49zkZ0rc1SXA7Tfh2h C/NE+zKeFLH+TyGMV58+7mPWyqo1BmhMsUkWPzlu0cKloB3eh+yPHBFWhU849tYC xLl9wNIHohfE09fZmchBRk9jUETgYIzSpm1Cth6dSrIo9maShjUZ4Ruad2H9Gz7R B3ncBRqar3R8DB3X8ZwAyvfhSP8BchCgimGU3qyETGZ2pkZmvWW+2CNSLVl4S+pA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrtddtgdegtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghgucfm jfcuoehgrhgvghfmjfeslhhinhhugihfohhunhgurghtihhonhdrohhrgheqnecuggftrf grthhtvghrnheptedvleegfffguddtledvvddtteffjeetgfevveeugefgleelhfevveef udeuuddvnecukfhppeekfedrkeeirdejgedrieegnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorghhrdgtohhm X-ME-Proxy: Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) by mail.messagingengine.com (Postfix) with ESMTPA id 33E7C306468F; Tue, 15 Sep 2020 10:01:01 -0400 (EDT) Date: Tue, 15 Sep 2020 16:00:58 +0200 From: Greg KH To: Oliver Neukum Cc: linux-usb@vger.kernel.org Subject: Re: [PATCH 2/2] UAS: fix disconnect by unplugging a hub Message-ID: <20200915140058.GA914700@kroah.com> References: <20200915134501.13947-1-oneukum@suse.com> <20200915134501.13947-3-oneukum@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200915134501.13947-3-oneukum@suse.com> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Sep 15, 2020 at 03:45:01PM +0200, Oliver Neukum wrote: > The SCSI layer can go into an ugly loop if you ignore that a device > is gone. You need to report an error in the command rather than > in the return value of the queue method. > We need to specifically check for ENODEV.. > > Signed-off-by: Oliver Neukum > --- > drivers/usb/storage/uas.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) Should this one go to the stable kernels? thanks, greg k-h