From: Tom Rini Date: Tue, 15 Sep 2020 11:00:47 -0400 Subject: [PATCH] include: phy: fix NULL pointer check in phy_write() In-Reply-To: References: <20200818003108.30061-1-thiruan@linux.microsoft.com> Message-ID: <20200915150047.GI5110@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Sep 15, 2020 at 04:23:02PM +0200, Michal Simek wrote: > Hi Tom, > > ?t 18. 8. 2020 v 2:31 odes?latel Thirupathaiah Annapureddy > napsal: > > > > phy_write() uses bus->write() instead of bus->read(). This means NULL > > pointer pre-check needs to happen on bus->write instead of bus->read. > > > > Signed-off-by: Thirupathaiah Annapureddy > > --- > > include/phy.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/phy.h b/include/phy.h > > index 1dbbf65111..cbdb10d6fc 100644 > > --- a/include/phy.h > > +++ b/include/phy.h > > @@ -205,7 +205,7 @@ static inline int phy_write(struct phy_device *phydev, int devad, int regnum, > > { > > struct mii_dev *bus = phydev->bus; > > > > - if (!bus || !bus->read) { > > + if (!bus || !bus->write) { > > debug("%s: No bus configured\n", __func__); > > return -1; > > } > > -- > > 2.25.2 > > > > Please also take this patch to your tree. OK, will do. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: