Content-Type: multipart/mixed; boundary="===============2682295409038360723==" MIME-Version: 1.0 From: Ye Bin To: mptcp at lists.01.org Subject: [MPTCP] [PATCH v2] mptcp: Fix unsigned 'max_seq' compared with zero in mptcp_data_queue_ofo Date: Wed, 16 Sep 2020 19:41:04 +0800 Message-ID: <20200916114104.1556846-1-yebin10@huawei.com> X-Status: X-Keywords: X-UID: 5896 --===============2682295409038360723== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Fixes coccicheck warnig: net/mptcp/protocol.c:164:11-18: WARNING: Unsigned expression compared with = zero: max_seq > 0 Fixes: ab174ad8ef76 ("mptcp: move ooo skbs into msk out of order queue") Reported-by: Hulk Robot Signed-off-by: Ye Bin --- net/mptcp/protocol.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index ef0dd2f23482..3b71f6202524 100644 --- a/net/mptcp/protocol.c +++ b/net/mptcp/protocol.c @@ -155,13 +155,14 @@ static void mptcp_data_queue_ofo(struct mptcp_sock *m= sk, struct sk_buff *skb) { struct sock *sk =3D (struct sock *)msk; struct rb_node **p, *parent; + int space; u64 seq, end_seq, max_seq; struct sk_buff *skb1; = seq =3D MPTCP_SKB_CB(skb)->map_seq; end_seq =3D MPTCP_SKB_CB(skb)->end_seq; - max_seq =3D tcp_space(sk); - max_seq =3D max_seq > 0 ? max_seq + msk->ack_seq : msk->ack_seq; + space =3D tcp_space(sk); + max_seq =3D space > 0 ? space + msk->ack_seq : msk->ack_seq; = pr_debug("msk=3D%p seq=3D%llx limit=3D%llx empty=3D%d", msk, seq, max_seq, RB_EMPTY_ROOT(&msk->out_of_order_queue)); -- = 2.25.4 --===============2682295409038360723==--