Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E013C433E2 for ; Thu, 17 Sep 2020 13:17:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6A2C2072E for ; Thu, 17 Sep 2020 13:17:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726827AbgIQNRg (ORCPT ); Thu, 17 Sep 2020 09:17:36 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:40610 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726959AbgIQNQi (ORCPT ); Thu, 17 Sep 2020 09:16:38 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kItlt-00F597-Aw; Thu, 17 Sep 2020 15:16:21 +0200 Date: Thu, 17 Sep 2020 15:16:21 +0200 From: Andrew Lunn To: Florian Fainelli Cc: netdev@vger.kernel.org, hkallweit1@gmail.com, kuba@kernel.org, davem@davemloft.net Subject: Re: [PATCH net 2/2] net: phy: Do not warn in phy_stop() on PHY_DOWN Message-ID: <20200917131621.GM3526428@lunn.ch> References: <20200917034310.2360488-1-f.fainelli@gmail.com> <20200917034310.2360488-3-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200917034310.2360488-3-f.fainelli@gmail.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Sep 16, 2020 at 08:43:10PM -0700, Florian Fainelli wrote: > When phy_is_started() was added to catch incorrect PHY states, > phy_stop() would not be qualified against PHY_DOWN. It is possible to > reach that state when the PHY driver has been unbound and the network > device is then brought down. > > Fixes: 2b3e88ea6528 ("net: phy: improve phy state checking") > Signed-off-by: Florian Fainelli Reviewed-by: Andrew Lunn Andrew