Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19EDFC43461 for ; Thu, 17 Sep 2020 14:25:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C93532075B for ; Thu, 17 Sep 2020 14:25:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727477AbgIQOZT (ORCPT ); Thu, 17 Sep 2020 10:25:19 -0400 Received: from verein.lst.de ([213.95.11.211]:56535 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727530AbgIQOY7 (ORCPT ); Thu, 17 Sep 2020 10:24:59 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 8BA4668C65; Thu, 17 Sep 2020 16:14:40 +0200 (CEST) Date: Thu, 17 Sep 2020 16:14:39 +0200 From: Christoph Hellwig To: =?iso-8859-1?Q?=C6var_Arnfj=F6r=F0?= Bjarmason Cc: Theodore Ts'o , Linus Torvalds , Junio C Hamano , Christoph Hellwig , Git Mailing List , linux-fsdevel , Jacob Vosmaer Subject: Re: [PATCH] enable core.fsyncObjectFiles by default Message-ID: <20200917141439.GC27653@lst.de> References: <20180117184828.31816-1-hch@lst.de> <87h8rki2iu.fsf@evledraar.gmail.com> <20180117235220.GD6948@thunk.org> <87sgbghdbp.fsf@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87sgbghdbp.fsf@evledraar.gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Sep 17, 2020 at 01:06:50PM +0200, Ævar Arnfjörð Bjarmason wrote: > The reason is detailed in [1], tl;dr: empty loose object file issue on > ext4 allegedly caused by a lack of core.fsyncObjectFiles=true, but I > didn't do any root cause analysis. Just noting it here for for future > reference. All the modern Linux file systems first write the data, and then only write the metadata after the data write has finished. So your data might have been partially or fully on disk, but until the transaction to commit the size change and/or extent state change you're not going to be able to read it back.