From: Al Viro Subject: Re: [PATCH 2/5] fs,nfs: lift compat nfs4 mount data handling into the nfs code Date: Thu, 17 Sep 2020 18:16:04 +0100 Message-ID: <20200917171604.GW3421308@ZenIV.linux.org.uk> References: <20200917082236.2518236-1-hch@lst.de> <20200917082236.2518236-3-hch@lst.de> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20200917082236.2518236-3-hch@lst.de> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Hellwig Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , Trond Myklebust , Anna Schumaker , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org On Thu, Sep 17, 2020 at 10:22:33AM +0200, Christoph Hellwig wrote: > There is no reason the generic fs code should bother with NFS specific > binary mount data - lift the conversion into nfs4_parse_monolithic > instead. Considering the size of struct compat_nfs4_mount_data_v1... Do we really need to bother with that "copy in place, so we go through the fields backwards" logics? Just make that > +static void nfs4_compat_mount_data_conv(struct nfs4_mount_data *data) > +{ struct compat_nfs4_mount_data_v1 compat; compat = *(struct compat_nfs4_mount_data_v1 *)data; and copy the damnt thing without worrying about the field order...