From: Tom Rini Date: Fri, 18 Sep 2020 10:50:58 -0400 Subject: [PATCH] powerpc: reduce number of WATCHDOG_RESET calls from flush_cache In-Reply-To: References: <20200604093039.26781-1-rasmus.villemoes@prevas.dk> <47d06069-e8d6-5351-cd90-4ba53c458719@denx.de> Message-ID: <20200918145058.GU14816@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Sep 18, 2020 at 10:20:46AM +0200, Rasmus Villemoes wrote: > On 04/06/2020 12.31, Stefan Roese wrote: > > On 04.06.20 11:30, Rasmus Villemoes wrote: > >> Calling WATCHDOG_RESET for each and every cache line is overkill. > >> > >> In our case, the kernel image is a little over 7MB, and the almost > >> 500000 calls of WATCHDOG_RESET() adds about one second to the > >> boottime. > >> > >> I very highly doubt there's any real hardware where flushing 64K > >> from cache to memory takes more than a few milliseconds, so this > >> should be completely safe. Since it reduces the number of > >> WATCHDOG_RESET() calls by roughly a factor of 1000, the overhead from > >> those is practically eliminated. (Just in case the range flushed is so > >> small that it doesn't cross a 64K boundary, add a single > >> WATCHDOG_RESET() between the loops). > >> > >> 64K is chosen because that's also the default chunk size used by the > >> hashing algorithms, and when, say, a sha256 digest of a kernel image of > >> a few MB is being verified, that's almost guaranteed to be cache-cold, > >> so apart from the computations being done, the hashing is also bounded > >> by memory speed - so if 64K works for those cases, it should certainly > >> also work when memory access is the only thing being done. > >> > >> Signed-off-by: Rasmus Villemoes > > > > Reviewed-by: Stefan Roese > > Ping. This too should end up in -next "soon". Thanks. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: