Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CCF5C43468 for ; Mon, 21 Sep 2020 07:35:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A4A22158C for ; Mon, 21 Sep 2020 07:35:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A4A22158C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AB7CE6E21F; Mon, 21 Sep 2020 07:35:19 +0000 (UTC) Received: from mail3-167.sinamail.sina.com.cn (mail3-167.sinamail.sina.com.cn [202.108.3.167]) by gabe.freedesktop.org (Postfix) with SMTP id 4A0406E090 for ; Sun, 20 Sep 2020 02:19:47 +0000 (UTC) Received: from unknown (HELO localhost.localdomain)([222.131.67.153]) by sina.com with ESMTP id 5F66B76C00011DE7; Sun, 20 Sep 2020 09:59:10 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 86849628751 From: Hillf Danton To: Rob Clark Subject: Re: [PATCH 2/3] drm/atomic: Use kthread worker for nonblocking commits Date: Sun, 20 Sep 2020 09:58:58 +0800 Message-Id: <20200920015858.7756-1-hdanton@sina.com> In-Reply-To: <20200919193727.2093945-3-robdclark@gmail.com> References: <20200919193727.2093945-1-robdclark@gmail.com> MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 21 Sep 2020 07:34:44 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Hillf Danton , Peter Zijlstra , linux-arm-msm@vger.kernel.org, LKML , timmurray@google.com, David Airlie , dri-dev , Thomas Zimmermann , Tejun Heo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Sat, 19 Sep 2020 12:37:25 -0700 Rob Clark wrote: > > @@ -1797,6 +1797,7 @@ int drm_atomic_helper_commit(struct drm_device *dev, > struct drm_atomic_state *state, > bool nonblock) > { > + struct kthread_worker *worker = NULL; > int ret; > > if (state->async_update) { > @@ -1814,7 +1815,7 @@ int drm_atomic_helper_commit(struct drm_device *dev, > if (ret) > return ret; > > - INIT_WORK(&state->commit_work, commit_work); > + kthread_init_work(&state->commit_kwork, commit_work); > > ret = drm_atomic_helper_prepare_planes(dev, state); > if (ret) > @@ -1857,8 +1858,12 @@ int drm_atomic_helper_commit(struct drm_device *dev, > */ > > drm_atomic_state_get(state); > + > if (nonblock) > - queue_work(system_unbound_wq, &state->commit_work); > + worker = drm_atomic_pick_worker(state); > + > + if (worker) > + kthread_queue_work(worker, &state->commit_kwork); > else > commit_tail(state); A minor change in behavior: commit_tail() would have nothing to do with either worker or work, rather than the fallback in case no worker is available. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel