Date: Mon, 21 Sep 2020 10:10:34 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20200921091034.GC3221@work-vm> References: <20200916112250.760245-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200916112250.760245-1-stefanha@redhat.com> Subject: Re: [Virtio-fs] [PATCH] virtiofsd: document cache=auto default List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: virtio-fs@redhat.com, qemu-devel@nongnu.org * Stefan Hajnoczi (stefanha@redhat.com) wrote: > From: "Harry G. Coin" > > The virtiofsd --help output documents the cache=auto default value but > the man page does not. Fix this. > > Signed-off-by: Harry G. Coin > Signed-off-by: Stefan Hajnoczi Reviewed-by: Dr. David Alan Gilbert Thanks, I'll add it to the next pull. Dave > --- > docs/tools/virtiofsd.rst | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst > index e33c81ed41..352a29ce3c 100644 > --- a/docs/tools/virtiofsd.rst > +++ b/docs/tools/virtiofsd.rst > @@ -103,6 +103,7 @@ Options > forbids the FUSE client from caching to achieve best coherency at the cost of > performance. ``auto`` acts similar to NFS with a 1 second metadata cache > timeout. ``always`` sets a long cache lifetime at the expense of coherency. > + The default is ``auto``. > > Examples > -------- > -- > 2.26.2 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK