Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A632C43469 for ; Mon, 21 Sep 2020 15:28:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BCD42085B for ; Mon, 21 Sep 2020 15:28:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WQnyMbS9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BCD42085B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51084 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKNjf-0004AL-Lo for qemu-devel@archiver.kernel.org; Mon, 21 Sep 2020 11:28:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKNhT-0003CF-PP for qemu-devel@nongnu.org; Mon, 21 Sep 2020 11:25:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:32242) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kKNhO-0004iO-1x for qemu-devel@nongnu.org; Mon, 21 Sep 2020 11:25:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600701948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ty17NOniwf6ri61OCYkwg0VUKGt3Id+fVQ8gVGk0318=; b=WQnyMbS9tZrRYscszfms+9kc6Q85nkK2t/ddWKvOIYzHYqJqtuIR7lpZ0T/LMSU+xnR078 7VzEZUF6BbZeSI/jUxBVC752RxUYakEJw7MCRCME2keZ+OoSODVHCSLDH4eV880Ehe0TZE 7iMpJc2ITp2sPsr5yxAss4yiIdC6wkQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-120-K5ZBWPuKMSKJohnS6f09dQ-1; Mon, 21 Sep 2020 11:25:43 -0400 X-MC-Unique: K5ZBWPuKMSKJohnS6f09dQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 525EF18C520E; Mon, 21 Sep 2020 15:25:42 +0000 (UTC) Received: from localhost (unknown [10.10.67.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1155755765; Mon, 21 Sep 2020 15:25:41 +0000 (UTC) Date: Mon, 21 Sep 2020 11:25:41 -0400 From: Eduardo Habkost To: Robert Hoo Subject: Re: [PATCH v3 2/2] Mark Icelake-Client CPU models deprecated Message-ID: <20200921152541.GM57321@habkost.net> References: <1600245434-63021-1-git-send-email-robert.hu@linux.intel.com> <1600245434-63021-2-git-send-email-robert.hu@linux.intel.com> <20200917180158.GT7594@habkost.net> <20200918042036.GY7594@habkost.net> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/21 01:44:53 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.455, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, armbru@redhat.com, robert.hu@intel.com, pbonzini@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Sep 21, 2020 at 03:45:12PM +0800, Robert Hoo wrote: > On Fri, 2020-09-18 at 00:20 -0400, Eduardo Habkost wrote: > > On Fri, Sep 18, 2020 at 10:18:56AM +0800, Robert Hoo wrote: > > > On Thu, 2020-09-17 at 14:01 -0400, Eduardo Habkost wrote: > > > > On Wed, Sep 16, 2020 at 04:37:14PM +0800, Robert Hoo wrote: > > > > > Going to obsolete Icelake-Client CPU models in the future. > > > > > > > > > > Signed-off-by: Robert Hoo > > > > > --- > > > > > Change log > > > > > v3: > > > > > Obsolete in v5.2 --> v5.3. > > > > > > > > > > target/i386/cpu.c | 10 +++++++++- > > > > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > > > > > index 9cb82b7..15c1c00 100644 > > > > > --- a/target/i386/cpu.c > > > > > +++ b/target/i386/cpu.c > > > > > @@ -3467,7 +3467,12 @@ static X86CPUDefinition > > > > > builtin_x86_defs[] = > > > > > { > > > > > .xlevel = 0x80000008, > > > > > .model_id = "Intel Core Processor (Icelake)", > > > > > .versions = (X86CPUVersionDefinition[]) { > > > > > - { .version = 1 }, > > > > > + { > > > > > + .version = 1, > > > > > + .deprecated = true, > > > > > + .note = "Deprecated. Will be obsoleted in > > > > > v5.3. > > > > > Please use " > > > > > + "'Icelake-Server-v1' CPU model", > > > > > > > > What's the difference between "deprecated" and "obsoleted"? > > > > > > > > > > Forgive my non-native understanding on English word:-D > > > > No problem! I'm not a native speaker either. :-) > > > > > Here is my understanding: > > > 'Deprecate' is to express strong disapproval on the usage; but, can > > > still be used if user insists. > > > 'Obsolete' means not usable anymore. > > > > > > You can feel free to reword the note words. > > > Perhaps substitute 'removed' for 'obsolete' will be better. > > > > "Removed" would be clearer, yes. It's probably better to not > > mention the exact version, and just say it will be removed in > > the future. > > Then I would tend to agree with your suggestion of no specific > 'deprecation_note' at all; instead, a general warning message "will be > removed in the future" in machine_run_board_init(). That would work too, but having "please use Icelake-Server instead" would reduce user confusion. It would also be consistent with how MachineClass does it, and make it easier to combine those two APIs together in the future. It's not a hard requirement, though. I'm OK if you want to keep it as simple as possible. > > > > Or maybe just make the message shorter and set deprecation_note > > to "Please use Icelake-Server instead". The details can be > > documented in docs/system/deprecated.rst. > > > Prefer documenting detail and model specific deprecation plan in > docs/system/deprecated.rst. > -- Eduardo