From: Christoph Hellwig Subject: Re: [PATCH 03/13] bcache: inherit the optimal I/O size Date: Mon, 21 Sep 2020 20:18:41 +0200 Message-ID: <20200921181841.GB2067@lst.de> References: <20200921080734.452759-1-hch@lst.de> <20200921080734.452759-4-hch@lst.de> <20200921140010.GA14672@lst.de> <5bcc52dc-ca8f-bbdd-69ef-4b6312e7994a@suse.de> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <5bcc52dc-ca8f-bbdd-69ef-4b6312e7994a@suse.de> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Coly Li Cc: Christoph Hellwig , Jens Axboe , Song Liu , Hans de Goede , Richard Weinberger , Minchan Kim , Johannes Thumshirn , Justin Sanders , linux-mtd@lists.infradead.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-raid@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org On Mon, Sep 21, 2020 at 11:09:48PM +0800, Coly Li wrote: > I feel this is something should be fixed. Indeed I overlooked it until > you point out the issue now. > > The optimal request size and read ahead pages hint are necessary, but > current initialization is simple. A better way might be dynamically > setting them depends on the cache mode and some special configuration. > > By your inspiration, I want to ACK your original patch although it > doesn't work fine for all condition. Then we may know these two settings > (ra_pages and queue_io_opt) should be improved for more situations. At > lease for most part of the situations they provide proper hints. > > How do you think of the above idea ? Sounds like a plan. I'd reall like to get this series in to get some soaking before the end of the merge window, but we should still have plenty of time for localized bcache updates.