Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3CD9C2D0E2 for ; Tue, 22 Sep 2020 11:30:28 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FE5D239D2 for ; Tue, 22 Sep 2020 11:30:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="R53u6bAr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FE5D239D2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8E77516FB; Tue, 22 Sep 2020 13:29:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8E77516FB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1600774225; bh=K85oP2JzJuryzOt/UY5Zuqxd/y+TDY32vyc1uiBl4Tc=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=R53u6bArAxhNtm06dC2+ZSVJCS2YoFvuiD0up60oIg0qc9TDC6830QJM8WGUY2vT0 CPGrHutja5VAOTc8+a1XQj7A8Z6nmJ8DFsWVCJ3Ae4Ur+e/zpw6nZ7Df/MQ0CtWvU8 U7gMUF9RdCTvH1EceL8xKyMq3Ii2ERZILnUaDJzc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1BE4AF8015F; Tue, 22 Sep 2020 13:29:35 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C180EF80229; Tue, 22 Sep 2020 13:29:31 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0D620F800ED for ; Tue, 22 Sep 2020 13:29:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0D620F800ED IronPort-SDR: 9LpY6tWp+DDLgP68Q4LZlpNA2jmjkNJ4iy2xamCbt+n24aREB/v8t221nRe+7RrNuqSMu7ItZL O2SmzJZeXdgg== X-IronPort-AV: E=McAfee;i="6000,8403,9751"; a="159872726" X-IronPort-AV: E=Sophos;i="5.77,290,1596524400"; d="scan'208";a="159872726" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 04:29:18 -0700 IronPort-SDR: JJoprP5cXbgG3TXYZ4DXw/jFiegSrdVM3xtnEt1HEPqblvMy6dL9y/3SkumPH/tRcJXsihk9K9 2Lz4kmqBOw+g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,290,1596524400"; d="scan'208";a="338262646" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 22 Sep 2020 04:29:14 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kKgTu-0014wV-Eh; Tue, 22 Sep 2020 14:29:10 +0300 Date: Tue, 22 Sep 2020 14:29:10 +0300 From: Andy Shevchenko To: "Rojewski, Cezary" Subject: Re: [PATCH v7 03/14] ASoC: Intel: catpt: Add IPC message handlers Message-ID: <20200922112910.GM3956970@smile.fi.intel.com> References: <20200921115424.4105-1-cezary.rojewski@intel.com> <20200921115424.4105-4-cezary.rojewski@intel.com> <20200921125934.GT3956970@smile.fi.intel.com> <55266617b42843839fb85309d3097fd6@intel.com> <20200921184129.GH3956970@smile.fi.intel.com> <191afe965b1e46799bf776be3254d28f@intel.com> <20200922090442.GJ3956970@smile.fi.intel.com> <4e51e628f9df457c8253a3ef6d7095eb@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4e51e628f9df457c8253a3ef6d7095eb@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Cc: "pierre-louis.bossart@linux.intel.com" , "alsa-devel@alsa-project.org" , "Kaczmarski, Filip" , "N, Harshapriya" , "gregkh@linuxfoundation.org" , "Barlik, Marcin" , "zwisler@google.com" , "lgirdwood@gmail.com" , "tiwai@suse.com" , "Proborszcz, Filip" , "broonie@kernel.org" , "amadeuszx.slawinski@linux.intel.com" , "Wasko, Michal" , "cujomalainey@chromium.org" , "Hejmowski, Krzysztof" , "Papierkowski, Piotr \(Habana\)" , "Gopal, Vamshi Krishna" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Sep 22, 2020 at 11:04:31AM +0000, Rojewski, Cezary wrote: > On 2020-09-22 11:04 AM, Andy Shevchenko wrote: > > On Mon, Sep 21, 2020 at 08:48:12PM +0000, Rojewski, Cezary wrote: > >> On 2020-09-21 8:41 PM, Andy Shevchenko wrote: > > ... > > >> While this should never happen (means user is somehow not making use of > >> officially released firmware binary), coredumps are useful only if you > >> have access to debug tools. In cases you'd mentioned, invalid hash would > >> have been dumped to coredump and crash reader simply wouldn't have been > >> able to navigate to actual build for it. The rest of the coredump is still > >> vital though. > >> > >> memcpy() could be gated behind an 'if' for safety if needed: > >> > >> info = cdev->ipc.config.fw_info; > >> eof = info + FW_INFO_SIZE_MAX; > >> /* navigate to fifth info segment (fw hash) */ > >> for (i = 0; i < 4 && info < eof; i++, info++) > >> /* info segments are separated by space each */ > >> if ((info = strnchr(info, eof - info, ' ')) == NULL) > >> break; > > > >> if (i == 4 && info < eof) > >> memcpy(pos, info, min(eof - info, CATPT_DUMP_HASH_SIZE)); > > > > And here basically enough check is info against NULL, right? > > Just try to look at different possibilities how to make code simpler and neater. > > > >> Didn't compile this, some typecheck fixes might be in order and so on. > > > > What you meant is: > if (i == 4 && !info) // instead of 'info < eof' > > right? Simply if (!info)... > If 4th space is last char in this string then info would end up being > non-NULL and equal to 'eof' and thus memcpy() would get invoked with > size=eof-info=0. ...which is not a problem. > catpt_coredump() is here to gather debug info for Intel folks to analyze > in case of critical error. In ideal world, it should not be required at > all as when we get here, there are bigger problems on our head. > Above solution is simpler than what is prevent in v7 while also > maintaining good readability - variable names - plus comments which you > suggested. Thanks! -- With Best Regards, Andy Shevchenko