Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75C6BC4727C for ; Wed, 30 Sep 2020 01:57:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 28A112145D for ; Wed, 30 Sep 2020 01:57:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="f+Lz62Y7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729999AbgI3B5X (ORCPT ); Tue, 29 Sep 2020 21:57:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:51206 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729982AbgI3B5X (ORCPT ); Tue, 29 Sep 2020 21:57:23 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1601431041; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ED2Rm9yQjkzhTx0dFHOgYPzukyrCoriVlWajPBcFhiA=; b=f+Lz62Y7WP0mDWWuWDJT8l3LX8rkNqrMvvFpFqxEuymw5ookNiRPk7onmrSMuy87Cm6iT6 jgcoVJG+icjt9FDrWbBSDXxl1oGtuEv9oGa0wI8/UrAgSt1JHJH/26QN5mTucAmC8xsAy0 mDgmAUYxG+6VR7mIC6f8FzwkU9UosdM= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AFFCEAF99 for ; Wed, 30 Sep 2020 01:57:21 +0000 (UTC) From: Qu Wenruo To: linux-btrfs@vger.kernel.org Subject: [PATCH v3 47/49] btrfs: extent_io: introduce submit_btree_subpage() to submit a page for subpage metadata write Date: Wed, 30 Sep 2020 09:55:37 +0800 Message-Id: <20200930015539.48867-48-wqu@suse.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200930015539.48867-1-wqu@suse.com> References: <20200930015539.48867-1-wqu@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org The new function, submit_btree_subpage(), will submit all the dirty extent buffers in the page. The major difference between submit_btree_page() is: - Page locking sequence Now we lock page first then lock extent buffers, thus we don't need to unlock the page just after writting one extent buffer. The page get unlocked after we have submitted all extent buffers. - Bio submission Since one extent buffer is ensured to be contained into one page, we call submit_extent_page() directly. Signed-off-by: Qu Wenruo --- fs/btrfs/extent_io.c | 69 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 69 insertions(+) diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index be8c863f7806..bd79b3531a75 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -4185,6 +4185,72 @@ static noinline_for_stack int write_one_eb(struct extent_buffer *eb, return ret; } +/* + * A helper to submit one subpage btree page. + * + * The main difference between submit_btree_page() is: + * - Page locking sequence + * Page are locked first, then lock extent buffers + * + * - Flush write bio + * We only flush bio if we may be unable to fit current extent buffers into + * current bio. + * + * Return >=0 for the number of submitted extent buffers. + * Return <0 for fatal error. + */ +static int submit_btree_subpage(struct page *page, + struct writeback_control *wbc, + struct extent_page_data *epd) +{ + struct btrfs_fs_info *fs_info = page_to_fs_info(page); + int submitted = 0; + u64 page_start = page_offset(page); + u64 page_end = page_start + PAGE_SIZE - 1; + u64 cur = page_start; + int ret; + + /* Lock the page first */ + lock_page(page); + + /* Then lock and write each extent buffers in the range */ + while (cur <= page_end) { + struct extent_buffer *eb; + + ret = btrfs_find_first_subpage_eb(fs_info, &eb, cur, page_end, + EXTENT_DIRTY); + if (ret > 0) + break; + ret = atomic_inc_not_zero(&eb->refs); + if (!ret) + continue; + + cur = eb->start + eb->len; + ret = lock_extent_buffer_for_io(eb, epd); + if (ret == 0) { + free_extent_buffer(eb); + continue; + } + if (ret < 0) { + free_extent_buffer(eb); + goto cleanup; + } + ret = write_one_eb(eb, wbc, epd); + free_extent_buffer(eb); + if (ret < 0) + goto cleanup; + submitted++; + } + unlock_page(page); + return submitted; + +cleanup: + unlock_page(page); + /* We hit error, end bio for the submitted extent buffers */ + end_write_bio(epd, ret); + return ret; +} + /* * A helper to submit a btree page. * @@ -4210,6 +4276,9 @@ static int submit_btree_page(struct page *page, struct writeback_control *wbc, if (!PagePrivate(page)) return 0; + if (btrfs_is_subpage(page_to_fs_info(page))) + return submit_btree_subpage(page, wbc, epd); + spin_lock(&mapping->private_lock); if (!PagePrivate(page)) { spin_unlock(&mapping->private_lock); -- 2.28.0