Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8653C4727C for ; Thu, 1 Oct 2020 10:37:10 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA4772085B for ; Thu, 1 Oct 2020 10:37:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Ifg3WHMb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="LdxUUxgG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA4772085B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id ACD5F1753; Thu, 1 Oct 2020 12:36:17 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz ACD5F1753 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1601548627; bh=ewFY7O6DbqdErsFVkxZ7UW2BHGUEWRBqZ/rbJc1c+qg=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Ifg3WHMbMPGB9QleEAPxPLQAeq7VdFnYcYtr00yzO42BKkPUQ3lXypO1IYXJms++f TD3pU5Fvh4oSlTmZAbh2bclpDZYNhbzqV39P2y4FXoSOmkG/vmEN3hGyfU7SiVU/KF 3E8SHV3QZiGVSc6AjXJ4DUfhAUif2IWL601EZUn4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3E3C4F801DB; Thu, 1 Oct 2020 12:36:17 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4C80BF801F5; Thu, 1 Oct 2020 12:36:15 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 33204F800AB for ; Thu, 1 Oct 2020 12:36:04 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 33204F800AB Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="LdxUUxgG" Received: from localhost (unknown [122.167.37.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C181B20796; Thu, 1 Oct 2020 10:36:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601548562; bh=ewFY7O6DbqdErsFVkxZ7UW2BHGUEWRBqZ/rbJc1c+qg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LdxUUxgGEYOvXW8zS8/4hUkJbMZBie2fIPUa5mEmHIxrLivocor+tdwIzp8qJeZVE Ihkow5DhEfH1IlJHwUEaKIYoAyFWGAYuetD2GEGxdA29RJOFYJaaSylVi5iBJHMwxa bTaKJh208W6rVXlWX1xf9FoXYfapbJK1+GyRP6V8= Date: Thu, 1 Oct 2020 16:05:58 +0530 From: Vinod Koul To: Takashi Iwai Subject: Re: [PATCH] ALSA: compress: allow pause and resume during draining Message-ID: <20201001103558.GV2968@vkoul-mobl> References: <000c01d69585$228db6b0$67a92410$@samsung.com> <7ba714ce-8b33-1b64-7503-6b155bf43909@perex.cz> <000f01d69603$10573fb0$3105bf10$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: alsa-devel@alsa-project.org, khw0178.kim@samsung.com, lgirdwood@gmail.com, kimty@samsung.com, tiwai@suse.com, 'Pierre-Louis Bossart' , s47.kang@samsung.com, hmseo@samsung.com, Gyeongtaek Lee , pilsun.jang@samsung.com, tkjung@samsung.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 30-09-20, 11:35, Takashi Iwai wrote: > On Tue, 29 Sep 2020 19:27:17 +0200, > Jaroslav Kysela wrote: > > BTW: Offtopic - Why compress code returns EPERM if the state is not correct? > > It's not about the permissions. The EBADFD is much better code in this case. That would be me ;-) > Indeed that sounds inconsistent, but I'm afraid it too late to change? > Suppose some code already depending on the error code. Who knows... The probability of that seems lesser ;D ... There are no public upstream users who would care about this. Only public use is QC dragon board and we use tinyplay, which does not care. Downstream Android HAL would care but chances of them looking at this error code are less (i will check with Qualcomm HAL to see)... Should we try fixing it? -- ~Vinod