Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kO2pC-0008E8-SR for mharc-qemu-trivial@gnu.org; Thu, 01 Oct 2020 13:57:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39322) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kO2p3-0008BV-Gx for qemu-trivial@nongnu.org; Thu, 01 Oct 2020 13:56:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:20100) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kO2p0-0008GU-KM for qemu-trivial@nongnu.org; Thu, 01 Oct 2020 13:56:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601575008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FIvUOwW3qme1A3loFSMi1+8exHY8qAY72cgyMrRkcO8=; b=R23NOxMg9zkTNGzmYa++Gi9WM0aL97f0q3RRRbUJCLc0kWPYXMxo2zreQoZg5yZ3nNyiOJ hnhmweQdEtcRGXPb1aqGEUpiG+2Y7GyJ5dYisJtmWeQRIXoPXRkBYMMtONBqpdHZeL5GXN gJIgihrt0cuYT9dsE/j7RFO7lECPRbg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-576-Aw7a2JZWPxyuG8SsH8cRWQ-1; Thu, 01 Oct 2020 13:56:45 -0400 X-MC-Unique: Aw7a2JZWPxyuG8SsH8cRWQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8312E801AB1; Thu, 1 Oct 2020 17:56:44 +0000 (UTC) Received: from localhost (unknown [10.10.67.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4041655770; Thu, 1 Oct 2020 17:56:44 +0000 (UTC) Date: Thu, 1 Oct 2020 13:56:42 -0400 From: Eduardo Habkost To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Paolo Bonzini , qemu-trivial@nongnu.org, Marcel Apfelbaum , Richard Henderson Subject: Re: [PATCH] hw/core/cpu: Add missing 'exec/cpu-common.h' include Message-ID: <20201001175642.GH3717385@habkost.net> References: <20200908123433.105706-1-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/01 02:15:30 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2020 17:56:55 -0000 On Thu, Oct 01, 2020 at 07:44:57PM +0200, Philippe Mathieu-Daudé wrote: > ping? > > On 9/8/20 2:34 PM, Philippe Mathieu-Daudé wrote: > > cpu_common_reset() uses tcg_flush_softmmu_tlb() which is > > declared in "exec/cpu-common.h". Add the missing header > > to avoid when refactoring other headers: > > > > hw/core/cpu.c: In function ‘cpu_common_reset’: > > hw/core/cpu.c:273:9: error: implicit declaration of function ‘tcg_flush_softmmu_tlb’ [-Werror=implicit-function-declaration] > > 273 | tcg_flush_softmmu_tlb(cpu); > > | ^~~~~~~~~~~~~~~~~~~~~ > > > > Signed-off-by: Philippe Mathieu-Daudé Qeueued, thanks! -- Eduardo