Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAEE6C4363C for ; Fri, 2 Oct 2020 17:48:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D5B6206DD for ; Fri, 2 Oct 2020 17:48:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZTLbFHhV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D5B6206DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOPAi-0004CG-FY for qemu-devel@archiver.kernel.org; Fri, 02 Oct 2020 13:48:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOP6n-0000XM-SV for qemu-devel@nongnu.org; Fri, 02 Oct 2020 13:44:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:44763) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kOP6l-00046q-E8 for qemu-devel@nongnu.org; Fri, 02 Oct 2020 13:44:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601660677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HIea7y7X+NxBpHc47NyrmUwfwINqhs69uPOP9YCfci8=; b=ZTLbFHhV4iOZPZXLzLwIbzsDkzPAEBeNQjyXCUCBw/vjPhqm3JveKpc6O76sgrDcys7kcn xPG7MtP3vecKXaCGkREPrPXop38ABgeCBFom/EbLxneAsuML9WVZkQRwxJTUQgQgRhD43c TOZthFY2WiakUC9FiOfRLoGs57r5Fuo= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-580-X5em2jJwPkiNsLnZFUi5lw-1; Fri, 02 Oct 2020 13:44:35 -0400 X-MC-Unique: X5em2jJwPkiNsLnZFUi5lw-1 Received: by mail-qv1-f70.google.com with SMTP id ct11so1272031qvb.16 for ; Fri, 02 Oct 2020 10:44:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HIea7y7X+NxBpHc47NyrmUwfwINqhs69uPOP9YCfci8=; b=bsADje/iYyHQz5GzPR6E7Yg+6CevHoEx5KaVzPPVUCqAYzOJmTQg252aoQD9HiEkh1 jzYmARO5+HoSmhTnFFPla/3zRGqko+SQcngxoqTKe6V9XLWqcjb+G62fB2oz+J1r+AeF by5IPMQxvNlDH3ZYdD2nC0Y7HG3glpJQF1vxbpSQLS5iQ60O+SFyeAADQORXHM2e4SZ4 d8yMepunB0dK1VZgfiXvlzEHikN5VpGlbKijEhYEU7tH42QvIhpTS+8qDg57u23aOTiy OAYxcGbXdIgxe8ZiXZ4DGX8/5WrUFoWO0jVEVoXGKbUNmZ+CjGFFVw+M8F+TJ0pN1rUR 1CAg== X-Gm-Message-State: AOAM533ZR/TQ/PjzdsGWfrLbjRPe+hVBs5NNZig0HT2OHXrtORn7qnbA UFOOOrFrc68v0aZhJMbnxMyRJINZimzdqw7pxeDdAG20KH3M4Wa/jNNo6FkUuQNj/tmYparcM0O MmMYD3m/Taq5gZYU= X-Received: by 2002:aed:3ee7:: with SMTP id o36mr3442883qtf.244.1601660674747; Fri, 02 Oct 2020 10:44:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwg4VgrGKGPkMF9NeKXatid1AH3tc3wg8UQjvOXc9SwfgcGXpQbkhkhJjsAJFMLJ291weJCRA== X-Received: by 2002:aed:3ee7:: with SMTP id o36mr3442848qtf.244.1601660674408; Fri, 02 Oct 2020 10:44:34 -0700 (PDT) Received: from xz-x1 (toroon474qw-lp130-09-184-147-14-204.dsl.bell.ca. [184.147.14.204]) by smtp.gmail.com with ESMTPSA id d21sm1491077qtp.97.2020.10.02.10.44.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2020 10:44:33 -0700 (PDT) Date: Fri, 2 Oct 2020 13:44:32 -0400 From: Peter Xu To: "Dr. David Alan Gilbert" Subject: Re: [PATCH v3 4/4] migration: Sync requested pages after postcopy recovery Message-ID: <20201002174432.GC5473@xz-x1> References: <20201001182641.80232-1-peterx@redhat.com> <20201001182641.80232-5-peterx@redhat.com> <20201002172646.GL3286@work-vm> MIME-Version: 1.0 In-Reply-To: <20201002172646.GL3286@work-vm> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/01 23:37:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Xiaohui Li , qemu-devel@nongnu.org, Juan Quintela Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Oct 02, 2020 at 06:26:46PM +0100, Dr. David Alan Gilbert wrote: > > + trace_postcopy_page_req_sync((uint64_t)(uintptr_t)host_addr); > > Again that's a case for host_addr and a %p I think. Yeah, I'll fix both places and repost. Thanks. -- Peter Xu