From: Marcelo Ricardo Leitner Date: Sat, 03 Oct 2020 04:09:15 +0000 Subject: Re: [PATCH net-next 12/15] sctp: call sk_setup_caps in sctp_packet_transmit instead Message-Id: <20201003040915.GH70998@localhost.localdomain> List-Id: References: <3716fc0699dc1d5557574b5227524e80b7fd76b8.1601387231.git.lucien.xin@gmail.com> In-Reply-To: <3716fc0699dc1d5557574b5227524e80b7fd76b8.1601387231.git.lucien.xin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Xin Long Cc: network dev , linux-sctp@vger.kernel.org, Neil Horman , Michael Tuexen , Tom Herbert , davem@davemloft.net On Tue, Sep 29, 2020 at 09:49:04PM +0800, Xin Long wrote: > sk_setup_caps() was originally called in Commit 90017accff61 ("sctp: > Add GSO support"), as: > > "We have to refresh this in case we are xmiting to more than one > transport at a time" > > This actually happens in the loop of sctp_outq_flush_transports(), > and it shouldn't be gso related, so move it out of gso part and To be more precise, "shouldn't be tied to gso" > before sctp_packet_pack().