From: Marcelo Ricardo Leitner Date: Sat, 03 Oct 2020 04:12:17 +0000 Subject: Re: [PATCH net-next 15/15] sctp: enable udp tunneling socks Message-Id: <20201003041217.GI70998@localhost.localdomain> List-Id: References: <780b235b6b4446f77cfcf167ba797ce1ae507cf1.1601387231.git.lucien.xin@gmail.com> In-Reply-To: <780b235b6b4446f77cfcf167ba797ce1ae507cf1.1601387231.git.lucien.xin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Xin Long Cc: network dev , linux-sctp@vger.kernel.org, Neil Horman , Michael Tuexen , Tom Herbert , davem@davemloft.net On Tue, Sep 29, 2020 at 09:49:07PM +0800, Xin Long wrote: > This patch is to enable udp tunneling socks by calling > sctp_udp_sock_start() in sctp_ctrlsock_init(), and > sctp_udp_sock_stop() in sctp_ctrlsock_exit(). > > Also add sysctl udp_port to allow changing the listening > sock's port by users. > > Wit this patch, the whole sctp over udp feature can be With > enabled and used. ... > @@ -1466,6 +1466,10 @@ static int __net_init sctp_ctrlsock_init(struct net *net) > if (status) > pr_err("Failed to initialize the SCTP control sock\n"); > > + status = sctp_udp_sock_start(net); This can be masking the previous error. > + if (status) > + pr_err("Failed to initialize the SCTP udp tunneling sock\n"); SCTP UDP > + > return status; > } > This is the last comment I had. Thanks Xin! Nice patches.