Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D34E0C4727D for ; Sun, 4 Oct 2020 08:31:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60DB8206C3 for ; Sun, 4 Oct 2020 08:31:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="G0kWsGE4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725830AbgJDIbz (ORCPT ); Sun, 4 Oct 2020 04:31:55 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:53590 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725825AbgJDIbz (ORCPT ); Sun, 4 Oct 2020 04:31:55 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 93E852A2; Sun, 4 Oct 2020 10:31:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1601800313; bh=ASvvRjputQfL6yjUwONkjJypc9Q6ZmfRu4QYQFDVMlQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G0kWsGE48yiSNWGcYecbLlSgiBfBtT4ebF0a1KSibFuxEJqIa8SyzTwh83xSir46M Cx9mapHKaIzyOFeJcq4qASg/ta8hbsSPRKCXsSfOUmjXRi9kMH3fV6fiHJXD1dCLxz tQRBV2Ka2xXyFoa3+qMWNTjhPItianWDqE1PDbIw= Date: Sun, 4 Oct 2020 11:31:15 +0300 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, jmondi@jmondi.org Subject: Re: [PATCH 1/5] adv748x: Zero entire struct v4l2_fwnode_endpoint Message-ID: <20201004083115.GB3938@pendragon.ideasonboard.com> References: <20200930144811.16612-1-sakari.ailus@linux.intel.com> <20200930144811.16612-2-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200930144811.16612-2-sakari.ailus@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Sakari, Thank you for the patch. On Wed, Sep 30, 2020 at 05:48:07PM +0300, Sakari Ailus wrote: > The v4l2_fwnode_parse_endpoint() function can make use of defaults in > multiple bus types. To use this feature, all callers must zero the rest of > the fields of this struct, too. All other drivers appear to do that > already apart from this one. > > Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart > --- > drivers/media/i2c/adv748x/adv748x-core.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c > index 1fe7f97c6d52..ae8b7ebf3830 100644 > --- a/drivers/media/i2c/adv748x/adv748x-core.c > +++ b/drivers/media/i2c/adv748x/adv748x-core.c > @@ -589,14 +589,13 @@ static int adv748x_parse_csi2_lanes(struct adv748x_state *state, > unsigned int port, > struct device_node *ep) > { > - struct v4l2_fwnode_endpoint vep; > + struct v4l2_fwnode_endpoint vep = { .bus_type = V4L2_MBUS_CSI2_DPHY }; > unsigned int num_lanes; > int ret; > > if (port != ADV748X_PORT_TXA && port != ADV748X_PORT_TXB) > return 0; > > - vep.bus_type = V4L2_MBUS_CSI2_DPHY; > ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(ep), &vep); > if (ret) > return ret; -- Regards, Laurent Pinchart