Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69750C4363A for ; Mon, 5 Oct 2020 09:42:24 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DFC52080C for ; Mon, 5 Oct 2020 09:42:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="uqrALd0R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DFC52080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9F23E17ED; Mon, 5 Oct 2020 11:41:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9F23E17ED DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1601890941; bh=auLg/p+Iiu9xNms+H85J37ZsIeR7OtaSm1BYd43xYes=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=uqrALd0Rm1a+fSSBsBOFlK8tr0QIHsxhP0NAU6KMX7YV/C3VZ0FDP78HMxaGLUnVw rYoaWmc1kmk4Wpx8ozRkVi7vwXB/IgunDAusAQYAPmnk1d5YlAhzH5V7eFE/3y56tZ CRfQsTOq2dtk/ohghvhIArsDBB50DXp/gf97WTtk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 061DAF80245; Mon, 5 Oct 2020 11:41:31 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1C1D8F800EF; Mon, 5 Oct 2020 11:41:30 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1379CF800EF for ; Mon, 5 Oct 2020 11:41:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1379CF800EF IronPort-SDR: /U+48tgMw0OIU/AqwwHtoiVrvaC3Xdj3O+DoOhyZuirBYYU13QREhseqKpazA6dT96HGdPT1XH scHkIc2zbzsQ== X-IronPort-AV: E=McAfee;i="6000,8403,9764"; a="248100628" X-IronPort-AV: E=Sophos;i="5.77,338,1596524400"; d="scan'208";a="248100628" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2020 02:41:13 -0700 IronPort-SDR: cETmAbHmECIg0OyaIV86CRZXAVYdhIJmARLiO4U/dPWIpxXlqoH8QNrJA4UuebC6a65hzfiKgx 30M0J7V6MQLA== X-IronPort-AV: E=Sophos;i="5.77,338,1596524400"; d="scan'208";a="340827005" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2020 02:41:09 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kPMzP-004aJE-Tw; Mon, 05 Oct 2020 12:41:03 +0300 Date: Mon, 5 Oct 2020 12:41:03 +0300 From: Andy Shevchenko To: Cezary Rojewski Subject: Re: [PATCH 00/13] ASoC: Intel: Remove obsolete solutions and Message-ID: <20201005094103.GN3956970@smile.fi.intel.com> References: <20201004100128.5842-1-cezary.rojewski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201004100128.5842-1-cezary.rojewski@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Cc: pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, filip.kaczmarski@intel.com, harshapriya.n@intel.com, marcin.barlik@intel.com, zwisler@google.com, lgirdwood@gmail.com, tiwai@suse.com, filip.proborszcz@intel.com, broonie@kernel.org, amadeuszx.slawinski@linux.intel.com, michal.wasko@intel.com, cujomalainey@chromium.org, krzysztof.hejmowski@intel.com, ppapierkowski@habana.ai, vamshi.krishna.gopal@intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sun, Oct 04, 2020 at 12:01:15PM +0200, Cezary Rojewski wrote: > Follow up to catpt series as mentioned in: > [PATCH v10 00/14] ASoC: Intel: Catpt - Lynx and Wildcat point > https://www.spinics.net/lists/alsa-devel/msg116440.html > > As catpt is a direct replacement to sound/soc/intel/haswell, it leaves a > lot of code redudant. The second legacy solution - baytrail - is > deprecated for a long time by sound/soc/intel/atom with SOF flavor > available too. > > This series addresses the redudancy and removes obsolete code. Along > with the legacy solutions, all orphaned components are removed too. > > As a consequence, further cleanups are unlocked: sound/soc/intel/skylake > becomes the sole user of processing code found in > sound/soc/intel/common. Those are not part of this series. Completely in favour of this series, thanks! FWIW, Reviewed-by: Andy Shevchenko > Cezary Rojewski (13): > ASoC: Intel: Remove haswell solution > ASoC: Intel: Remove max98090 support for baytrail solution > ASoC: Intel: Remove rt5640 support for baytrail solution > ASoC: Intel: Remove baytrail solution > ASoC: Intel: Remove SST ACPI component > ASoC: Intel: Remove SST firmware components > ASoC: Intel: Skylake: Unassign ram_read and read_write ops > ASoC: Intel: Remove unused DSP operations > ASoC: Intel: Remove unused DSP interface fields > ASoC: Intel: Remove SST-legacy specific constants > ASoC: Intel: Make atom components independent of sst-dsp > ASoC: Intel: Remove sst_pdata structure > ASoC: Intel: Remove sst_dsp_get_thread_context > > include/sound/soc-acpi-intel-match.h | 1 - > include/trace/events/hswadsp.h | 385 --- > sound/soc/intel/Kconfig | 26 - > sound/soc/intel/Makefile | 1 - > sound/soc/intel/atom/sst/sst.c | 1 - > sound/soc/intel/atom/sst/sst.h | 7 + > sound/soc/intel/atom/sst/sst_acpi.c | 1 - > sound/soc/intel/atom/sst/sst_drv_interface.c | 3 - > sound/soc/intel/atom/sst/sst_ipc.c | 1 - > sound/soc/intel/atom/sst/sst_loader.c | 1 - > sound/soc/intel/atom/sst/sst_pvt.c | 1 - > sound/soc/intel/atom/sst/sst_stream.c | 1 - > sound/soc/intel/baytrail/Makefile | 5 - > sound/soc/intel/baytrail/sst-baytrail-dsp.c | 358 --- > sound/soc/intel/baytrail/sst-baytrail-ipc.c | 772 ------ > sound/soc/intel/baytrail/sst-baytrail-ipc.h | 64 - > sound/soc/intel/baytrail/sst-baytrail-pcm.c | 459 ---- > sound/soc/intel/boards/Kconfig | 25 - > sound/soc/intel/boards/Makefile | 4 - > sound/soc/intel/boards/byt-max98090.c | 182 -- > sound/soc/intel/boards/byt-rt5640.c | 224 -- > sound/soc/intel/boards/bytcht_es8316.c | 1 - > sound/soc/intel/boards/bytcr_rt5640.c | 1 - > sound/soc/intel/common/Makefile | 4 - > .../intel/common/soc-acpi-intel-byt-match.c | 15 - > sound/soc/intel/common/sst-acpi.c | 236 -- > sound/soc/intel/common/sst-dsp-priv.h | 284 +-- > sound/soc/intel/common/sst-dsp.c | 162 -- > sound/soc/intel/common/sst-dsp.h | 222 -- > sound/soc/intel/common/sst-firmware.c | 1273 ---------- > sound/soc/intel/common/sst-ipc.c | 27 - > sound/soc/intel/common/sst-ipc.h | 3 - > sound/soc/intel/haswell/Makefile | 5 - > sound/soc/intel/haswell/sst-haswell-dsp.c | 705 ------ > sound/soc/intel/haswell/sst-haswell-ipc.c | 2222 ----------------- > sound/soc/intel/haswell/sst-haswell-ipc.h | 527 ---- > sound/soc/intel/haswell/sst-haswell-pcm.c | 1369 ---------- > sound/soc/intel/skylake/bxt-sst.c | 2 - > sound/soc/intel/skylake/cnl-sst.c | 4 +- > sound/soc/intel/skylake/skl-sst-dsp.c | 2 +- > sound/soc/intel/skylake/skl-sst-ipc.c | 2 +- > sound/soc/intel/skylake/skl-sst.c | 2 - > 42 files changed, 11 insertions(+), 9579 deletions(-) > delete mode 100644 include/trace/events/hswadsp.h > delete mode 100644 sound/soc/intel/baytrail/Makefile > delete mode 100644 sound/soc/intel/baytrail/sst-baytrail-dsp.c > delete mode 100644 sound/soc/intel/baytrail/sst-baytrail-ipc.c > delete mode 100644 sound/soc/intel/baytrail/sst-baytrail-ipc.h > delete mode 100644 sound/soc/intel/baytrail/sst-baytrail-pcm.c > delete mode 100644 sound/soc/intel/boards/byt-max98090.c > delete mode 100644 sound/soc/intel/boards/byt-rt5640.c > delete mode 100644 sound/soc/intel/common/sst-acpi.c > delete mode 100644 sound/soc/intel/common/sst-firmware.c > delete mode 100644 sound/soc/intel/haswell/Makefile > delete mode 100644 sound/soc/intel/haswell/sst-haswell-dsp.c > delete mode 100644 sound/soc/intel/haswell/sst-haswell-ipc.c > delete mode 100644 sound/soc/intel/haswell/sst-haswell-ipc.h > delete mode 100644 sound/soc/intel/haswell/sst-haswell-pcm.c > > -- > 2.17.1 > -- With Best Regards, Andy Shevchenko