Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kPTZy-0004bl-UF for mharc-qemu-trivial@gnu.org; Mon, 05 Oct 2020 12:43:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44414) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPTZx-0004ZH-98 for qemu-trivial@nongnu.org; Mon, 05 Oct 2020 12:43:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:50646) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kPTZu-0000Uo-5L for qemu-trivial@nongnu.org; Mon, 05 Oct 2020 12:43:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601916189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bx9ny2N/hJHfH080rCM9p5MudFlrDdrUBXo/4kq13As=; b=BUQxVIEROle+8lyxLl/obhWDPSXmuTl17SAK+72SaRvhE7VgUEGXW40aqy8j2Z6D8dwV0b +JHowoyPLJJ1VMCXHeUhNlZNgx4oWUkGO+ch35JhD398kJJOzIsLXrYzKw4hIb/l4eiNXp voXsnCdGuiE5tDtAQYaeShoS88di9WU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-432-rPQyvLqyMN-yZAtw0oPN7A-1; Mon, 05 Oct 2020 12:43:07 -0400 X-MC-Unique: rPQyvLqyMN-yZAtw0oPN7A-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EAFE718FE86C; Mon, 5 Oct 2020 16:42:44 +0000 (UTC) Received: from localhost (ovpn-119-102.rdu2.redhat.com [10.10.119.102]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC2BF277CF; Mon, 5 Oct 2020 16:42:44 +0000 (UTC) Date: Mon, 5 Oct 2020 12:42:44 -0400 From: Eduardo Habkost To: Paolo Bonzini Cc: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [PATCH] qom: Improve error message displayed with missing object properties Message-ID: <20201005164244.GK7303@habkost.net> References: <20200920155340.401482-1-f4bug@amsat.org> <0263e47d-549e-8acb-a6cb-93a7436f5f6d@redhat.com> MIME-Version: 1.0 In-Reply-To: <0263e47d-549e-8acb-a6cb-93a7436f5f6d@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/05 01:25:11 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.733, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Oct 2020 16:43:13 -0000 On Mon, Oct 05, 2020 at 10:46:38AM +0200, Paolo Bonzini wrote: > On 20/09/20 17:53, Philippe Mathieu-Daudé wrote: > > Instead of only displaying the property missing, also display > > the object name. This help developer to quickly figure out the > > mistake without opening a debugger. > > > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > qom/object.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/qom/object.c b/qom/object.c > > index 387efb25ebe..257914b1fe3 100644 > > --- a/qom/object.c > > +++ b/qom/object.c > > @@ -1259,7 +1259,8 @@ ObjectProperty *object_property_find(Object *obj, const char *name, > > return prop; > > } > > > > - error_setg(errp, "Property '.%s' not found", name); > > + error_setg(errp, "Property '%s.%s' not found", > > + object_get_typename(obj), name); > > return NULL; > > } > > > > > > Acked-by: Paolo Bonzini > > I think it's okay for qemu-trivial. It would be okay, but it doesn't apply on master anymore due to the object_propert_find_err() refactor. I've fixed the conflicts and queued it on machine-next. -- Eduardo