From: dann frazier Subject: Re: [PATCH] device: return error for unknown chipsets Date: Tue, 6 Oct 2020 10:43:32 -0600 Message-ID: <20201006164332.GA1172704@xps13.dannf> References: <20201005135230.735914-1-kherbst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20201005135230.735914-1-kherbst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Karol Herbst Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: nouveau.vger.kernel.org On Mon, Oct 05, 2020 at 03:52:30PM +0200, Karol Herbst wrote: > Previously the code relied on device->pri to be NULL and to fail probing > later. We really should just return an error inside nvkm_device_ctor for > unsupported GPUs. > > Fixes: 24d5ff40a732 ("drm/nouveau/device: rework mmio mapping code to get rid of second map") > Signed-off-by: Karol Herbst > Cc: dann frazier Thanks Karol! Got rid of the Oops for me. Tested-by: dann frazier Would it be appropriate to tag this for stable v5.8+? -dann > --- > drm/nouveau/nvkm/engine/device/base.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drm/nouveau/nvkm/engine/device/base.c b/drm/nouveau/nvkm/engine/device/base.c > index 9f4ac2672..68d665414 100644 > --- a/drm/nouveau/nvkm/engine/device/base.c > +++ b/drm/nouveau/nvkm/engine/device/base.c > @@ -3149,6 +3149,7 @@ nvkm_device_ctor(const struct nvkm_device_func *func, > case 0x168: device->chip = &nv168_chipset; break; > default: > nvdev_error(device, "unknown chipset (%08x)\n", boot0); > + ret = -ENOSYS; > goto done; > } >