Received: by 2002:ac2:4c26:0:0:0:0:0 with SMTP id u6csp1771373lfq; Thu, 8 Oct 2020 16:26:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwqIWfZoL220D7B1ish4be6K/SQYcpOic+oRYSxqIObpYDsKn6Bydaxybr9yfTUMZb3aj0 X-Received: by 2002:a25:aa2e:: with SMTP id s43mr13294902ybi.500.1602199575473; Thu, 08 Oct 2020 16:26:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602199575; cv=none; d=google.com; s=arc-20160816; b=pa2s8M5/AeOKwk0CvrM7vT30TEFon5mP01nLiCmPxU+Kfs7IVplbZg61u6JPgT4/yu 630/KLL87ja6inaqW3BOt92sGh8mQDGYMhLooRgPwugAz5IwDYQ2oJLJtA60PCUx4II2 Dk2aFSO5LpByw0hYlhAncz+msDFmO3bqOM+buyKDlQ80uxHcP7ZsEi2AIoZl5CpYfSAd HSKC3FfTm/pVo0weexan5oHgzCi1OOaYE0kQT2PC6a5igfYkaqbht7NMz6Xb2aFCdF+W Ia+BnB+hYCmnnIqmHUi6zikJz5dKx+9MKsOsxkuCMeGti/mpPtoAEb/Pb7oFREWUcdNj qIwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=from:reply-to:sender:errors-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:cc:to:subject :references:mime-version:message-id:in-reply-to:date:dkim-signature; bh=VSo/jKl59ost3zY2rF027mpXits1fjog3XXWueOC/4o=; b=TrkV0lWJSRLI9tvoq2d67+Fqi+jUqmhkfDm8hWrarA1EMbe/O71ImGzEBVP5OmyFNF XVtcwBAMFdJI1AgQtbaeZWJOMmR9LbQukOzVGuyIL001Ns3g84U18Btvx+Vo1xg7xoaJ v6/du3XAg9uQZ9WkTHhrApETYyGO4DgY4PXuI5b907Mu79IClajAeMCS+Ydh5TieTjE8 n4ZfG0mbJW4tXvUQRyZ12sjZzAIjeIJLkPc3Bvp3jobn3AaRfSamakagDwl9DRgBDwgZ GslDIN+9rbePxpYIV5D3qMX1rkGj12dv+tD98O3cOpSUJry3eTVZy8hzuOGd81vs9h4q R0+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@google.com header.s=20161025 header.b=vyUzBRNo; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id j66si6074075ybb.93.2020.10.08.16.26.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Oct 2020 16:26:15 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@google.com header.s=20161025 header.b=vyUzBRNo; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nongnu.org Received: from localhost ([::1]:44446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQfIc-0007Tg-QR for alex.bennee@linaro.org; Thu, 08 Oct 2020 19:26:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51716) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <3Kp9_XwsKCGkOZRPUULTVLUNVVNSL.JVTXLTb-HYTUVUNUb.VYN@flex--hskinnemoen.bounces.google.com>) id 1kQfF1-0003wS-Jq for qemu-arm@nongnu.org; Thu, 08 Oct 2020 19:22:33 -0400 Received: from mail-pg1-x54a.google.com ([2607:f8b0:4864:20::54a]:41720) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <3Kp9_XwsKCGkOZRPUULTVLUNVVNSL.JVTXLTb-HYTUVUNUb.VYN@flex--hskinnemoen.bounces.google.com>) id 1kQfEt-0002tK-7M for qemu-arm@nongnu.org; Thu, 08 Oct 2020 19:22:31 -0400 Received: by mail-pg1-x54a.google.com with SMTP id 24so4958411pgm.8 for ; Thu, 08 Oct 2020 16:22:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=VSo/jKl59ost3zY2rF027mpXits1fjog3XXWueOC/4o=; b=vyUzBRNok8Av/HjdhmcTqLX4xYQwQxqM23b2JT+HFHKPj+XSZy5QMHxp/HbmcFOcJH 3CkKdoMULNpFl/kW7b8XzbgdfabcCw0TVVktD73KmnMROmZ7yWL80Y2T1s+H21BvWjR1 6fVtcVSuqDBTyQt3r9ZRxQ0QkVNioZUI3pdnpj6tCnAj6Jn+lQkmsbW1Uxt90ymUpqhf haB3S20pXFxhYaHyZBIK5XmnBLNZt/Gq9Fh1po2DPOrLEqKo6VAnPhvQxbm/OBIUD9LC VwqSQJgaqVPBNidhbN9ITbOL3FZEd0O2dy7gmqFpU4yFQa+NzaS1Y3sq0YS2tso/SZd9 6KtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=VSo/jKl59ost3zY2rF027mpXits1fjog3XXWueOC/4o=; b=V54j8VKW5qsuhoK5jl8foK8+He7VFwWm4UUJUzhEhH6loUzh0c4TivQoGgtRS+j4Jm OksGXp+oxpCmYFWzkgm9qRai7Z3v+o/XL+eROeOiLKxfQD7f68Ov3BDiZvJigBJSvNLT HUatKliylxcbmcMdqGVaYN6l0tk9/vEe+NXtv0mvz2vOmsGTtV8D9q7FIhPzZ4SNCBoH EwfHqssn6gzfemRW0IP/X0M692Gr8/RiekCQsKBEugz/4GJErQxh7sfsDAlLELlg+eB9 GVHPJyq3NesqLFcN0FQGSXwbnCFmaimIZRX5HwuREMZsgoApzlOo3Ma+hiKkWPZnSAf1 4KjA== X-Gm-Message-State: AOAM531VaKYOosJX2z+pjJQtEjgFe7WH3Oza7eFpFtDcpAeY3B6/AW0a BQNfpDujik/bU6MVdj6PDjq+ALtM9/UfmTbUjg== X-Received: from skybert.c.googlers.com ([fda3:e722:ac3:10:24:72f4:c0a8:3107]) (user=hskinnemoen job=sendgmr) by 2002:a17:902:6114:b029:d3:b2d3:44bd with SMTP id t20-20020a1709026114b02900d3b2d344bdmr9296989plj.59.1602199338408; Thu, 08 Oct 2020 16:22:18 -0700 (PDT) Date: Thu, 8 Oct 2020 16:21:53 -0700 In-Reply-To: <20201008232154.94221-1-hskinnemoen@google.com> Message-Id: <20201008232154.94221-6-hskinnemoen@google.com> Mime-Version: 1.0 References: <20201008232154.94221-1-hskinnemoen@google.com> X-Mailer: git-send-email 2.28.0.1011.ga647a8990f-goog Subject: [PATCH 5/6] hw/arm/npcm7xx: Add EHCI and OHCI controllers To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, peter.maydell@linaro.org, Avi.Fishman@nuvoton.com, kfting@nuvoton.com, f4bug@amsat.org, clg@kaod.org, Havard Skinnemoen , Gerd Hoffmann Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::54a; envelope-from=3Kp9_XwsKCGkOZRPUULTVLUNVVNSL.JVTXLTb-HYTUVUNUb.VYN@flex--hskinnemoen.bounces.google.com; helo=mail-pg1-x54a.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -95 X-Spam_score: -9.6 X-Spam_bar: --------- X-Spam_report: (-9.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" Reply-to: Havard Skinnemoen From: Havard Skinnemoen via X-TUID: KBM/0SBCL8j5 The NPCM730 and NPCM750 chips have a single USB host port shared between a USB 2.0 EHCI host controller and a USB 1.1 OHCI host controller. This adds support for both of them. Testing notes: * With -device usb-kbd, qemu will automatically insert a full-speed hub, and the keyboard becomes controlled by the OHCI controller. * With -device usb-kbd,bus=usb-bus.0,port=1, the keyboard is directly attached to the port without any hubs, and the device becomes controlled by the EHCI controller since it's high speed capable. * With -device usb-kbd,bus=usb-bus.0,port=1,usb_version=1, the keyboard is directly attached to the port, but it only advertises itself as full-speed capable, so it becomes controlled by the OHCI controller. In all cases, the keyboard device enumerates correctly. Cc: Gerd Hoffmann Reviewed-by: Tyrone Ting Signed-off-by: Havard Skinnemoen --- docs/system/arm/nuvoton.rst | 2 +- hw/usb/hcd-ehci.h | 1 + include/hw/arm/npcm7xx.h | 4 ++++ hw/arm/npcm7xx.c | 27 +++++++++++++++++++++++++-- hw/usb/hcd-ehci-sysbus.c | 19 +++++++++++++++++++ 5 files changed, 50 insertions(+), 3 deletions(-) diff --git a/docs/system/arm/nuvoton.rst b/docs/system/arm/nuvoton.rst index 4342434df4..99fc61c740 100644 --- a/docs/system/arm/nuvoton.rst +++ b/docs/system/arm/nuvoton.rst @@ -39,6 +39,7 @@ Supported devices * OTP controllers (no protection features) * Flash Interface Unit (FIU; no protection features) * Random Number Generator (RNG) + * USB host (USBH) Missing devices --------------- @@ -54,7 +55,6 @@ Missing devices * eSPI slave interface * Ethernet controllers (GMAC and EMC) - * USB host (USBH) * USB device (USBD) * SMBus controller (SMBF) * Peripheral SPI controller (PSPI) diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h index fd122dd4cd..a173707d9b 100644 --- a/hw/usb/hcd-ehci.h +++ b/hw/usb/hcd-ehci.h @@ -344,6 +344,7 @@ struct EHCIPCIState { #define TYPE_PLATFORM_EHCI "platform-ehci-usb" #define TYPE_EXYNOS4210_EHCI "exynos4210-ehci-usb" #define TYPE_AW_H3_EHCI "aw-h3-ehci-usb" +#define TYPE_NPCM7XX_EHCI "npcm7xx-ehci-usb" #define TYPE_TEGRA2_EHCI "tegra2-ehci-usb" #define TYPE_PPC4xx_EHCI "ppc4xx-ehci-usb" #define TYPE_FUSBH200_EHCI "fusbh200-ehci-usb" diff --git a/include/hw/arm/npcm7xx.h b/include/hw/arm/npcm7xx.h index 761f9b987e..aeee1beaaa 100644 --- a/include/hw/arm/npcm7xx.h +++ b/include/hw/arm/npcm7xx.h @@ -25,6 +25,8 @@ #include "hw/nvram/npcm7xx_otp.h" #include "hw/timer/npcm7xx_timer.h" #include "hw/ssi/npcm7xx_fiu.h" +#include "hw/usb/hcd-ehci.h" +#include "hw/usb/hcd-ohci.h" #include "target/arm/cpu.h" #define NPCM7XX_MAX_NUM_CPUS (2) @@ -77,6 +79,8 @@ typedef struct NPCM7xxState { NPCM7xxOTPState fuse_array; NPCM7xxMCState mc; NPCM7xxRNGState rng; + EHCISysBusState ehci; + OHCISysBusState ohci; NPCM7xxFIUState fiu[2]; } NPCM7xxState; diff --git a/hw/arm/npcm7xx.c b/hw/arm/npcm7xx.c index c4bbf3c7d5..ab37442d9c 100644 --- a/hw/arm/npcm7xx.c +++ b/hw/arm/npcm7xx.c @@ -46,6 +46,10 @@ #define NPCM7XX_MC_BA (0xf0824000) #define NPCM7XX_RNG_BA (0xf000b000) +/* USB Host modules */ +#define NPCM7XX_EHCI_BA (0xf0806000) +#define NPCM7XX_OHCI_BA (0xf0807000) + /* Internal AHB SRAM */ #define NPCM7XX_RAM3_BA (0xc0008000) #define NPCM7XX_RAM3_SZ (4 * KiB) @@ -90,6 +94,8 @@ enum NPCM7xxInterrupt { NPCM7XX_WDG0_IRQ = 47, /* Timer Module 0 Watchdog */ NPCM7XX_WDG1_IRQ, /* Timer Module 1 Watchdog */ NPCM7XX_WDG2_IRQ, /* Timer Module 2 Watchdog */ + NPCM7XX_EHCI_IRQ = 61, + NPCM7XX_OHCI_IRQ = 62, }; /* Total number of GIC interrupts, including internal Cortex-A9 interrupts. */ @@ -263,6 +269,9 @@ static void npcm7xx_init(Object *obj) object_initialize_child(obj, "tim[*]", &s->tim[i], TYPE_NPCM7XX_TIMER); } + object_initialize_child(obj, "ehci", &s->ehci, TYPE_NPCM7XX_EHCI); + object_initialize_child(obj, "ohci", &s->ohci, TYPE_SYSBUS_OHCI); + QEMU_BUILD_BUG_ON(ARRAY_SIZE(npcm7xx_fiu) != ARRAY_SIZE(s->fiu)); for (i = 0; i < ARRAY_SIZE(s->fiu); i++) { object_initialize_child(obj, npcm7xx_fiu[i].name, &s->fiu[i], @@ -379,6 +388,22 @@ static void npcm7xx_realize(DeviceState *dev, Error **errp) sysbus_realize(SYS_BUS_DEVICE(&s->rng), &error_abort); sysbus_mmio_map(SYS_BUS_DEVICE(&s->rng), 0, NPCM7XX_RNG_BA); + /* USB Host */ + object_property_set_bool(OBJECT(&s->ehci), "companion-enable", true, + &error_abort); + sysbus_realize(SYS_BUS_DEVICE(&s->ehci), &error_abort); + sysbus_mmio_map(SYS_BUS_DEVICE(&s->ehci), 0, NPCM7XX_EHCI_BA); + sysbus_connect_irq(SYS_BUS_DEVICE(&s->ehci), 0, + npcm7xx_irq(s, NPCM7XX_EHCI_IRQ)); + + object_property_set_str(OBJECT(&s->ohci), "masterbus", "usb-bus.0", + &error_abort); + object_property_set_uint(OBJECT(&s->ohci), "num-ports", 1, &error_abort); + sysbus_realize(SYS_BUS_DEVICE(&s->ohci), &error_abort); + sysbus_mmio_map(SYS_BUS_DEVICE(&s->ohci), 0, NPCM7XX_OHCI_BA); + sysbus_connect_irq(SYS_BUS_DEVICE(&s->ohci), 0, + npcm7xx_irq(s, NPCM7XX_OHCI_IRQ)); + /* * Flash Interface Unit (FIU). Can fail if incorrect number of chip selects * specified, but this is a programming error. @@ -463,8 +488,6 @@ static void npcm7xx_realize(DeviceState *dev, Error **errp) create_unimplemented_device("npcm7xx.mcphy", 0xf05f0000, 64 * KiB); create_unimplemented_device("npcm7xx.gmac1", 0xf0802000, 8 * KiB); create_unimplemented_device("npcm7xx.gmac2", 0xf0804000, 8 * KiB); - create_unimplemented_device("npcm7xx.ehci", 0xf0806000, 4 * KiB); - create_unimplemented_device("npcm7xx.ohci", 0xf0807000, 4 * KiB); create_unimplemented_device("npcm7xx.vcd", 0xf0810000, 64 * KiB); create_unimplemented_device("npcm7xx.ece", 0xf0820000, 8 * KiB); create_unimplemented_device("npcm7xx.vdma", 0xf0822000, 8 * KiB); diff --git a/hw/usb/hcd-ehci-sysbus.c b/hw/usb/hcd-ehci-sysbus.c index 3730736540..e3758db1b1 100644 --- a/hw/usb/hcd-ehci-sysbus.c +++ b/hw/usb/hcd-ehci-sysbus.c @@ -147,6 +147,24 @@ static const TypeInfo ehci_aw_h3_type_info = { .class_init = ehci_aw_h3_class_init, }; +static void ehci_npcm7xx_class_init(ObjectClass *oc, void *data) +{ + SysBusEHCIClass *sec = SYS_BUS_EHCI_CLASS(oc); + DeviceClass *dc = DEVICE_CLASS(oc); + + sec->capsbase = 0x0; + sec->opregbase = 0x10; + sec->portscbase = 0x44; + sec->portnr = 1; + set_bit(DEVICE_CATEGORY_USB, dc->categories); +} + +static const TypeInfo ehci_npcm7xx_type_info = { + .name = TYPE_NPCM7XX_EHCI, + .parent = TYPE_SYS_BUS_EHCI, + .class_init = ehci_npcm7xx_class_init, +}; + static void ehci_tegra2_class_init(ObjectClass *oc, void *data) { SysBusEHCIClass *sec = SYS_BUS_EHCI_CLASS(oc); @@ -269,6 +287,7 @@ static void ehci_sysbus_register_types(void) type_register_static(&ehci_platform_type_info); type_register_static(&ehci_exynos4210_type_info); type_register_static(&ehci_aw_h3_type_info); + type_register_static(&ehci_npcm7xx_type_info); type_register_static(&ehci_tegra2_type_info); type_register_static(&ehci_ppc4xx_type_info); type_register_static(&ehci_fusbh200_type_info); -- 2.28.0.1011.ga647a8990f-goog