Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4B68C433DF for ; Fri, 9 Oct 2020 13:27:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0DC7B22276 for ; Fri, 9 Oct 2020 13:27:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="AEYovlRc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DC7B22276 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D7F97900002; Fri, 9 Oct 2020 09:27:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D2FD06B0068; Fri, 9 Oct 2020 09:27:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C452E900002; Fri, 9 Oct 2020 09:27:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0235.hostedemail.com [216.40.44.235]) by kanga.kvack.org (Postfix) with ESMTP id 99DBF6B0062 for ; Fri, 9 Oct 2020 09:27:10 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2A1651EE6 for ; Fri, 9 Oct 2020 13:27:10 +0000 (UTC) X-FDA: 77352463020.22.maid02_0d11353271e1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 0783618038E60 for ; Fri, 9 Oct 2020 13:27:10 +0000 (UTC) X-HE-Tag: maid02_0d11353271e1 X-Filterd-Recvd-Size: 2211 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Fri, 9 Oct 2020 13:27:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tsezONzJMfkFX30+r+1t4DO2YlfenS+R1OBhP8jUdUY=; b=AEYovlRcHdYEmLvcxLmsViEwsK nKoePB6eopAL0DojvUsx94E683xebkX5h2Bmxop+w+oDYK+uh+OTa3M6A9mKpq1cr4YDefZKCCb4o AB80rGgrO142Y82BKLzybAHnnAxEK/q5hGHlAAm/rD5OjatOOJ0gJbxWxEuGJbO+4P31OIXbhT/ey /nchtyYT5BWOHx1ziy97Igd8tjvi0GHA6CqBk2ihImtKDvRbGLOwgn2s+OszweuxumxOkB3pQtbOn EB9TjlU9l4rh9EGpJUFHVOmZVMrGgPleeQVbYeoN0V6q6KpRv/8HtJGrZZmIMOfH9GYTwF63TEJ9s zGtEMmCQ==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQsQK-00027j-7w; Fri, 09 Oct 2020 13:27:04 +0000 Date: Fri, 9 Oct 2020 14:27:04 +0100 From: Matthew Wilcox To: "Huang, Ying" Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Rafael Aquini , Hugh Dickins , "Kirill A . Shutemov" , Andrea Arcangeli Subject: Re: [PATCH] mm: Fix a race during split THP Message-ID: <20201009132704.GS20115@casper.infradead.org> References: <20201009073647.1531083-1-ying.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201009073647.1531083-1-ying.huang@intel.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 09, 2020 at 03:36:47PM +0800, Huang, Ying wrote: > + if (PageSwapCache(head)) { > + swp_entry_t entry = { .val = page_private(head) }; > + > + split_swap_cluster(entry); > + } ... > - if (PageSwapCache(head)) { > - swp_entry_t entry = { .val = page_private(head) }; > - > - ret = split_swap_cluster(entry); Are we sure split_swap_cluster() can't fail? Or if it does fail, it's OK to continue with the split and not report the error?