Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58945C433E7 for ; Wed, 14 Oct 2020 08:10:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F1B77214D8 for ; Wed, 14 Oct 2020 08:10:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602663048; bh=jQ5S59AbY30aIviGY3+0Glt9cuVpa2j9ZL+Tla3OxPE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=N9ndUymsXYHqzzg60calrRaiWlnmNM8ErLY6jKvSqNqvy5XGnuVuv4XZAy7wBfHHS 7IMkqai+JsTOxINR3Spn52CVN+2S9yh/o9KBZ5t53U32CpkEd1n3gFbZdUCbs8xLaO JPIVZ4VxSbyfBmBWwPUUzJNcLILkn9/TDPCAolM4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727391AbgJNIKr (ORCPT ); Wed, 14 Oct 2020 04:10:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:47210 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727023AbgJNIKq (ORCPT ); Wed, 14 Oct 2020 04:10:46 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9DEB320BED; Wed, 14 Oct 2020 08:10:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602663044; bh=jQ5S59AbY30aIviGY3+0Glt9cuVpa2j9ZL+Tla3OxPE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q2wYRAUhDQxmHkmP0WHeDVNXvlatSrbDap/Shu4ccrF8wVFXwr0OBsmekzzHOkTb/ hcZ1REHwItQoSuGnMIvUp5wYp3EeIWdm9CoWvRbsFA9uxKRE6V5nsz2W+mnVKGBZu2 nUDvJSCBzr6BBeBW9VuJ0n5aKDX6QQUKSWNL/cAY= Date: Wed, 14 Oct 2020 10:11:19 +0200 From: Greg KH To: Ben Chuang Cc: sashal@kernel.org, stable@vger.kernel.org, Ben Chuang , greg.tu@genesyslogic.com.tw, seanhy.chen@genesyslogic.com.tw, Ulf Hansson Subject: Re: [PATCH] mmc: sdhci-pci-gli: Set SDR104's clock to 205MHz and enable SSC for GL975x Message-ID: <20201014081119.GA3009479@kroah.com> References: <20201013074600.9784-1-benchuanggli@gmail.com> <20201013080105.GA1681211@kroah.com> <20201013085806.GB1681211@kroah.com> <20201013134849.GA1968052@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Oct 14, 2020 at 04:00:49PM +0800, Ben Chuang wrote: > Hi Greg, > > On Tue, Oct 13, 2020 at 9:48 PM Greg KH wrote: > > > > On Tue, Oct 13, 2020 at 07:11:13PM +0800, Ben Chuang wrote: > > > On Tue, Oct 13, 2020 at 4:57 PM Greg KH wrote: > > > > > > > > On Tue, Oct 13, 2020 at 04:33:38PM +0800, Ben Chuang wrote: > > > > > On Tue, Oct 13, 2020 at 4:00 PM Greg KH wrote: > > > > > > > > > > > > On Tue, Oct 13, 2020 at 03:46:00PM +0800, Ben Chuang wrote: > > > > > > > From: Ben Chuang > > > > > > > > > > > > > > commit 786d33c887e15061ff95942db68fe5c6ca98e5fc upstream. > > > > > > > > > > > > > > Set SDR104's clock to 205MHz and enable SSC for GL9750 and GL9755 > > > > > > > > > > > > > > Signed-off-by: Ben Chuang > > > > > > > Link: https://lore.kernel.org/r/20200717033350.13006-1-benchuanggli@gmail.com > > > > > > > Signed-off-by: Ulf Hansson > > > > > > > Cc: # 5.4.x > > > > > > > --- > > > > > > > Hi Greg and Sasha, > > > > > > > > > > > > > > The patch is to improve the EMI of the hardware. > > > > > > > So it should be also required for some hardware devices using the v5.4. > > > > > > > Please tell me if have other questions. > > > > > > > > > > > > This looks like a "add support for new hardware" type of patch, right? > > > > > > > > > > No, this is for a mass production hardware. > > > > > > > > That does not make sense, sorry. > > > > > > > > Is this a bug that is being fixed, did the hardware work properly before > > > > 5.4 and now it does not? Or has it never worked properly and 5.9 is the > > > > first kernel that it now works on? > > > > > > It seems there is misunderstanding regarding “hardware” means. > > > I originally thought that the "hardware" refers to GL975x chips. > > > > > > This Genesys patch is to fix the EMI problem for GL975x controller on a system. > > > > Did it work on the 4.19 kernel? Another older kernel? Or is 5.9 the > > first kernel release where it works? > > The patch works on after v5.4. You are not answering the question I am trying to ask. My question is: Did this hardware ever work properly before the 5.9 kernel release. > > In other words, is this fixing a regression, or just enabling hardware > > support for something that has never worked before for this hardware? > > This patch is to reduce the EMI at SDR104 mode for GL975x. > It changes the preset frequency of SDR104 to 205Mhz and sets the SSC value. > So I think it is fixing a regression. A regression is when an older kernel works fine, but a newer kernel does not. When that happens, you can point to a specific commit and say, "this commit here broke this previously working hardware". Is that the case here? If not, this is not a regression. thanks, greg k-h