Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64BF7C433E7 for ; Wed, 14 Oct 2020 11:46:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A47D20BED for ; Wed, 14 Oct 2020 11:46:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388281AbgJNLqJ (ORCPT ); Wed, 14 Oct 2020 07:46:09 -0400 Received: from mx2.suse.de ([195.135.220.15]:57636 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730661AbgJNLp4 (ORCPT ); Wed, 14 Oct 2020 07:45:56 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F3CD7AC6D; Wed, 14 Oct 2020 11:45:41 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id E93E1DA7C3; Wed, 14 Oct 2020 13:44:14 +0200 (CEST) Date: Wed, 14 Oct 2020 13:44:14 +0200 From: David Sterba To: Qu Wenruo Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH] btrfs: space-info: fix the wrong trace name for bytes_may_use Message-ID: <20201014114414.GK6756@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Qu Wenruo , linux-btrfs@vger.kernel.org References: <20201012065624.80649-1-wqu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201012065624.80649-1-wqu@suse.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon, Oct 12, 2020 at 02:56:24PM +0800, Qu Wenruo wrote: > The trace_name for bytes_may_use should be "may_use", "space_info". > > Fixes: f3e75e3805e1 ("btrfs: roll tracepoint into btrfs_space_info_update helper") This patch reduced all calls to the definition and kept the same output, ie. the 'space_info' so it was correct and the Fixes does not seem to be right here. You should explain why the 'may_use' is supposed to be there.