Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E9A4C43457 for ; Fri, 16 Oct 2020 03:11:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F3C22087D for ; Fri, 16 Oct 2020 03:11:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602817900; bh=ZYjvwyI/eUwAgTG97KnHQSZMik8xQcTqfc6qJ2GjU1k=; h=Date:From:To:Subject:In-Reply-To:Reply-To:List-ID:From; b=0b9OoTZU+Sq6j6c4OMB4QXIgUap+mpo3iiXfQ2Y4icQWxZCHoG6lqfM25Rs+FD8Wx lRn/Qed8ROP/6/6LMlF9kdS1697702hSTiRyY66x3/W+t6IC+aQx97X+IZAYo9KBMW ec0Iw08VxF7sJ1Y/WxGz7HXG1GS4TZTSgJnC35i4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388506AbgJPDLj (ORCPT ); Thu, 15 Oct 2020 23:11:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:48108 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387864AbgJPDLj (ORCPT ); Thu, 15 Oct 2020 23:11:39 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E3BF720789; Fri, 16 Oct 2020 03:11:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602817899; bh=ZYjvwyI/eUwAgTG97KnHQSZMik8xQcTqfc6qJ2GjU1k=; h=Date:From:To:Subject:In-Reply-To:From; b=CNTUrH1z4pUe3kXE2jbOSOjz/7d9faDBHHeyA6w91vf70Jljqc+kQPeksE/9+Auzc YbG5697ABL9DMLCxTVKlgiJVD0jOr44wP70OZIJuQhpe6RREczjQZ2LQjevvhU46l3 7+0mRtkpy08rDrwvlH4UZcstLiWNu6Y28XZL3mv8= Date: Thu, 15 Oct 2020 20:11:38 -0700 From: Andrew Morton To: akpm@linux-foundation.org, corbet@lwn.net, kernel@cdqe.de, krzk@kernel.org, mchehab+huawei@kernel.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 118/156] lib/crc32.c: fix trivial typo in preprocessor condition Message-ID: <20201016031138.eTR-Two-5%akpm@linux-foundation.org> In-Reply-To: <20201015194043.84cda0c1d6ca2a6847f2384a@linux-foundation.org> User-Agent: s-nail v14.8.16 Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org From: Tobias Jordan Subject: lib/crc32.c: fix trivial typo in preprocessor condition Whether crc32_be needs a lookup table is chosen based on CRC_LE_BITS. Obviously, the _be function should be governed by the _BE_ define. This probably never pops up as it's hard to come up with a configuration where CRC_BE_BITS isn't the same as CRC_LE_BITS and as nobody is using bitwise CRC anyway. Link: https://lkml.kernel.org/r/20200923182122.GA3338@agrajag.zerfleddert.de Fixes: 46c5801eaf86 ("crc32: bolt on crc32c") Signed-off-by: Tobias Jordan Cc: Krzysztof Kozlowski Cc: Jonathan Corbet Cc: Mauro Carvalho Chehab Signed-off-by: Andrew Morton --- lib/crc32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/lib/crc32.c~lib-crc32c-fix-trivial-typo-in-preprocessor-condition +++ a/lib/crc32.c @@ -331,7 +331,7 @@ static inline u32 __pure crc32_be_generi return crc; } -#if CRC_LE_BITS == 1 +#if CRC_BE_BITS == 1 u32 __pure crc32_be(u32 crc, unsigned char const *p, size_t len) { return crc32_be_generic(crc, p, len, NULL, CRC32_POLY_BE); _