From: Sean Anderson Date: Sat, 17 Oct 2020 09:19:58 -0400 Subject: [PATCH] test: log: Actually test enable/disable output Message-ID: <20201017131959.31551-1-seanga2@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Strings are truth-y in python, so ``assert 'anything'`` will always evaluate to True. Fix the test so that it actually checks the output. Fixes: 3d03ab6361 ("log: Add a way to enable/disable a log device") Signed-off-by: Sean Anderson --- test/py/tests/test_log.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/py/tests/test_log.py b/test/py/tests/test_log.py index 275f9382d2..e8b2b17145 100644 --- a/test/py/tests/test_log.py +++ b/test/py/tests/test_log.py @@ -95,9 +95,9 @@ def test_log(u_boot_console): def test11(): """Test use of log_device_set_enable()""" lines = run_test(11) - assert 'log_test() default' + assert 'log_test() default' == next(lines) # disabled should not be displayed - assert 'log_test() enabled' + assert 'log_test() enabled' == next(lines) # TODO(sjg at chromium.org): Consider structuring this as separate tests cons = u_boot_console -- 2.28.0