Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B02FDC433DF for ; Mon, 19 Oct 2020 09:35:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D355322200 for ; Mon, 19 Oct 2020 09:35:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="1cTRPkWV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D355322200 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DC9AD6B005D; Mon, 19 Oct 2020 05:35:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D7A0D6B0062; Mon, 19 Oct 2020 05:35:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C41E66B0068; Mon, 19 Oct 2020 05:35:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id 967B36B005D for ; Mon, 19 Oct 2020 05:35:16 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 35497181AEF0B for ; Mon, 19 Oct 2020 09:35:16 +0000 (UTC) X-FDA: 77388166632.03.arm36_190686227236 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 0A63E28A4E8 for ; Mon, 19 Oct 2020 09:35:16 +0000 (UTC) X-HE-Tag: arm36_190686227236 X-Filterd-Recvd-Size: 4005 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Mon, 19 Oct 2020 09:35:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Zox4iuTUh5FhfHMfr5Q1+3mfA7F/sioi7RToa5+WOak=; b=1cTRPkWVb54NZZ9RoS/xBCH//y bQ8J6UD4Msz4eTlusz0Mg0XUPKXXee9CpA39JXkycYwfkuyW38XvZxx+Ov+bC+orngC/knAgKRe+V RSUEzGr/pQne1U7t+uJT4Ysxl9Fpg7ljYx9s0FfTJaon0FQp5khD6hZW6u9s5G0zQWlm88iGLMExl F7eXrCeoL/Iljfckg/PyFFE4SBgQQ6pDjaupvcpSCYQez3wm478Lf2zsTglmh+ANgPSXtxSN1OpD6 gPVw+tJxsfEjTgFZbH/pINcQlGxLK7zMigefRp0S20SP1O49vayTSnvv+EhM8QiQl4oc6BbeVvwcB veDuI0Gw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kURZL-0005n6-V6; Mon, 19 Oct 2020 09:35:08 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 6C3083011E6; Mon, 19 Oct 2020 11:35:02 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 4E27A21447780; Mon, 19 Oct 2020 11:35:02 +0200 (CEST) Date: Mon, 19 Oct 2020 11:35:02 +0200 From: Peter Zijlstra To: Ira Weiny Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Andy Lutomirski , Fenghua Yu , x86@kernel.org, Dave Hansen , Dan Williams , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH RFC V3 2/9] x86/fpu: Refactor arch_set_user_pkey_access() for PKS support Message-ID: <20201019093502.GH2628@hirez.programming.kicks-ass.net> References: <20201009194258.3207172-1-ira.weiny@intel.com> <20201009194258.3207172-3-ira.weiny@intel.com> <20201016105743.GK2611@hirez.programming.kicks-ass.net> <20201017033202.GV2046448@iweiny-DESK2.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201017033202.GV2046448@iweiny-DESK2.sc.intel.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 16, 2020 at 08:32:03PM -0700, Ira Weiny wrote: > On Fri, Oct 16, 2020 at 12:57:43PM +0200, Peter Zijlstra wrote: > > On Fri, Oct 09, 2020 at 12:42:51PM -0700, ira.weiny@intel.com wrote: > > > From: Fenghua Yu > > > > > > Define a helper, update_pkey_val(), which will be used to support both > > > Protection Key User (PKU) and the new Protection Key for Supervisor > > > (PKS) in subsequent patches. > > > > > > Co-developed-by: Ira Weiny > > > Signed-off-by: Ira Weiny > > > Signed-off-by: Fenghua Yu > > > --- > > > arch/x86/include/asm/pkeys.h | 2 ++ > > > arch/x86/kernel/fpu/xstate.c | 22 ++++------------------ > > > arch/x86/mm/pkeys.c | 21 +++++++++++++++++++++ > > > 3 files changed, 27 insertions(+), 18 deletions(-) > > > > This is not from Fenghua. > > > > https://lkml.kernel.org/r/20200717085442.GX10769@hirez.programming.kicks-ass.net > > > > This is your patch based on the code I wrote. > > Ok, I apologize. Yes the code below was all yours. > > Is it ok to add? > > Co-developed-by: Peter Zijlstra > Signed-off-by: Peter Zijlstra > Sure, thanks!