Received: by 2002:a19:6b17:0:0:0:0:0 with SMTP id d23csp3755845lfa; Mon, 19 Oct 2020 03:54:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwe0mVz3cJNSL6amDypPMC+HI6l8DNwGems4MCLPxBOXO09iI4u0/IMV47SDE2GD60pEuMb X-Received: by 2002:a25:db8c:: with SMTP id g134mr10957301ybf.146.1603104858353; Mon, 19 Oct 2020 03:54:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603104858; cv=none; d=google.com; s=arc-20160816; b=y4LQ2rVUQGAWNHjP5t9wZro96KUsx2nh7nxmB+N2QxWfVYFBQa/b5g6UfluOpS9fQE SFTb4MAWifdQaj7AWAH0w/IPcIrMNWn9tTbaF1PTGzdmMXKYwK9Dw1LeX9MWl8e8j1L/ EqHeh185SauwWDZWBOnbF3FjcbNvfbZNMNOKvtePNeGkUoT3XWATa5zH+Y2dNe1kv/Y+ J9UYYIylS43E+AbGKZkqq7oTVd84jvGpL1E3Wf9QCeD5wSAabGpazAxewHdKPIpm1NBq RT3bAI3XIHxdwlBci6kQnminC7qWkTUOwGTyJ0LZ/IjSX+og88htb+Gxy0AqHgNkEuqM /e4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=2EFiOg7D2B5V0bDgw9aEi/A66o6VokQxnytKxKGWgl8=; b=ABYR9vXwCdPe55CSKKKa5qqyJGgXwaXHRWASdpp+ML/lY3cDSQkt7SV77ChrB4pT9l eq2zHnf187fZy5aqxarrIJsaIhUJzFVJ27NuHlw0PHp8h7KsDt91YZbtfyxRnAbWmced kBysI52zXjBXuOAgBljSxe+LU6kZa6fRa7Xffc/vHH+4vYSAXbNxvRjAfrunAWRrad6y z5HAMIH4KD3f5/81xbz5RERtx5FrQxnCfQbnCE4gge+z8KaUvK9RXDlKESrkZwgrZmYx BWryAw57k+g9P2SFXXiiIklWy/ymG9crCi0Nzcepa2S7kzzi2Bw5a2EJZ01yK9Gx18S8 VSSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=J3vcUUnW; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id p127si9893919ybp.69.2020.10.19.03.54.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 19 Oct 2020 03:54:18 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=J3vcUUnW; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:54502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUSnx-0000rQ-Nq for alex.bennee@linaro.org; Mon, 19 Oct 2020 06:54:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUSep-0008OB-Nt for qemu-devel@nongnu.org; Mon, 19 Oct 2020 06:44:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34735) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kUSek-0000tj-J8 for qemu-devel@nongnu.org; Mon, 19 Oct 2020 06:44:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603104282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2EFiOg7D2B5V0bDgw9aEi/A66o6VokQxnytKxKGWgl8=; b=J3vcUUnWglipEpIZ+x1oxAqlCuK1Wj6cILFIlyxdZT6EeDAKHydtESatt6tTxOx+GCLv79 y2DK4uLL/5Bl9bb+MauXpwtLOGF6xELO5WqY2Mhx5l6Uto+0dVsu+YGyfGm8b9Eb4zmDca 25V3n2IYWHBdHhtK01pFf2lHPhjj9s8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-89-FQWYFocRNi--DyEG6KxriQ-1; Mon, 19 Oct 2020 06:44:40 -0400 X-MC-Unique: FQWYFocRNi--DyEG6KxriQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7B628186DD22; Mon, 19 Oct 2020 10:44:38 +0000 (UTC) Received: from eperezma.remote.csb (ovpn-113-59.ams2.redhat.com [10.36.113.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 90D1810013C4; Mon, 19 Oct 2020 10:44:16 +0000 (UTC) From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: qemu-devel@nongnu.org, Peter Xu , "Michael S. Tsirkin" Subject: [PATCH v2 4/5] intel_iommu: Skip page walking on device iotlb invalidations Date: Mon, 19 Oct 2020 12:43:31 +0200 Message-Id: <20201019104332.22033-5-eperezma@redhat.com> In-Reply-To: <20201019104332.22033-1-eperezma@redhat.com> References: <20201019104332.22033-1-eperezma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eperezma@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=eperezma@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/19 01:44:30 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Aleksandar Rikalo , Yan Zhao , Eduardo Habkost , Juan Quintela , qemu-ppc@nongnu.org, Jason Wang , Eric Auger , qemu-arm@nongnu.org, =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Avi Kivity , Paolo Bonzini , Richard Henderson , David Gibson Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: qLc/UACIU+4R Although they didn't reach the notifier because of the filtering in memory_region_notify_iommu_one, the vt-d was still splitting huge memory invalidations in chunks. Skipping it. This improves performance in case of netperf with vhost-net: * TCP_STREAM: From 1923.6Mbit/s to 2175.13Mbit/s (13%) * TCP_RR: From 8464.73 trans/s to 8932.703333 trans/s (5.5%) * UDP_RR: From 8562.08 trans/s to 9005.62/s (5.1%) * UDP_STREAM: No change observed (insignificant 0.1% improvement) Signed-off-by: Eugenio Pérez --- hw/i386/intel_iommu.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 6cc217742a..8f1ac137a6 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -1478,6 +1478,10 @@ static int vtd_sync_shadow_page_table(VTDAddressSpace *vtd_as) VTDContextEntry ce; IOMMUNotifier *n; + if (!(vtd_as->iommu.iommu_notify_flags & IOMMU_NOTIFIER_IOTLB_EVENTS)) { + return 0; + } + ret = vtd_dev_to_context_entry(vtd_as->iommu_state, pci_bus_num(vtd_as->bus), vtd_as->devfn, &ce); -- 2.18.1