Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25779C388F2 for ; Tue, 20 Oct 2020 15:40:38 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B07122249 for ; Tue, 20 Oct 2020 15:40:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="ERYbeiK4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B07122249 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.9705.25546 (Exim 4.92) (envelope-from ) id 1kUtk7-0002dr-6i; Tue, 20 Oct 2020 15:40:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 9705.25546; Tue, 20 Oct 2020 15:40:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUtk7-0002dk-1n; Tue, 20 Oct 2020 15:40:07 +0000 Received: by outflank-mailman (input) for mailman id 9705; Tue, 20 Oct 2020 15:40:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUtk5-0002VV-S7 for xen-devel@lists.xenproject.org; Tue, 20 Oct 2020 15:40:05 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e0852ae2-13c7-4a31-9846-626071fd9619; Tue, 20 Oct 2020 15:40:04 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUtk5-0002VV-S7 for xen-devel@lists.xenproject.org; Tue, 20 Oct 2020 15:40:05 +0000 X-Inumbo-ID: e0852ae2-13c7-4a31-9846-626071fd9619 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e0852ae2-13c7-4a31-9846-626071fd9619; Tue, 20 Oct 2020 15:40:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1603208404; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=6ISmU+JH6ZgpC176exqVC/z/+DWR4Rlaalo9uKhU8Bw=; b=ERYbeiK4/fEXAZffRCOO/2HtsL4AlhMJR8nQ1gjKKO+H7wOgTJcN/Z4f UxjYraCHppCEKTo+tm20HmOQNAqPKQNcaqcqchtfr58n+ktyLPKmrxqDM NHrkYr2PcTDn1HvhZ9F50HVtOBks8LzFtnzw+GDwdI4/fPl9RiPLsobdj o=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: ty+Xv5mccCX3qSWAgpu110vkMzwbup7wE1qWzSeXT+vIKnmmzjwpV3C1Pa30GbCulyCoJoRiT3 CGTVI/Vh5uriWlUeGGp0GM/lw9HV/57Tf6obCdTiF10mKWMgQSSi0iaOFtJ4W7CZAq8owe9Wp5 oMPkllspQrg4C/P4zqnfe9jU3Cuea1t0kRpZ/NHO6BTnqSnojfPe8fMkLkVf0Bn3laC6jxbQkA dyfrJHE4ZvBFkEta8WkCyZ8Xb4Z4DMxw8bte4quRNtZOKphHUCYEfFFUQGnOHKx+Dpoxc5/zGX tUM= X-SBRS: None X-MesageID: 29641228 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.77,397,1596513600"; d="scan'208";a="29641228" Date: Tue, 20 Oct 2020 16:39:59 +0100 From: Anthony PERARD To: Jason Andryuk CC: , Ian Jackson , "Wei Liu" Subject: Re: [PATCH] libxl: Add suppress-vmdesc to QEMU -machine pc options Message-ID: <20201020153959.GA2214@perard.uk.xensource.com> References: <20201019200050.103360-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20201019200050.103360-1-jandryuk@gmail.com> On Mon, Oct 19, 2020 at 04:00:50PM -0400, Jason Andryuk wrote: > The device model state saved by QMP xen-save-devices-state doesn't > include the vmdesc json. When restoring an HVM, xen-load-devices-state > always triggers "Expected vmdescription section, but got 0". This is > not a problem when restore comes from a file. However, when QEMU runs > in a linux stubdom and comes over a console, EOF is not received. This > causes a delay restoring - though it does restore. > > Setting suppress-vmdesc skips looking for the vmdesc during restore and > avoids the wait. > > This is a libxl change for the non-xenfv case to match the xenfv change > made in qemu > > Signed-off-by: Jason Andryuk > --- > > Should this also add suppress-vmdesc to xenfv for backwards > compatibility? In that case, the change in QEMU is redundent. Since > this only really matters for the stubdom case, it could be conditioned > on that. QEMU doesn't complain about having suppress-vmdesc set on the command line and as a default for the xenfv machine, so I don't mind adding it to the xenfv machine in libxl, while keeping the change in QEMU. The change is already applied to QEMU, so unless there's an issue, I don't want to revert it. It might be useful for tool stacks that don't use libxl. Also, the change matters as well for non-stubdom cases as it removed a cryptic error message from qemu-dm's logs :-). Thanks, -- Anthony PERARD