Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58DCFC4363A for ; Thu, 22 Oct 2020 08:23:24 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 99CC82065D for ; Thu, 22 Oct 2020 08:23:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99CC82065D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4B2D5A928; Thu, 22 Oct 2020 10:23:10 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id A18F9A908 for ; Thu, 22 Oct 2020 10:23:08 +0200 (CEST) IronPort-SDR: dsFjuSOs72DAiRLijAoZG183qRLTA+NU8dJ+YgRzHlumq9w8JOJsFwqrA1P0LBcXRJVsOeBXw+ NbCarIdUb7cA== X-IronPort-AV: E=McAfee;i="6000,8403,9781"; a="154445143" X-IronPort-AV: E=Sophos;i="5.77,404,1596524400"; d="scan'208";a="154445143" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2020 01:23:06 -0700 IronPort-SDR: uph2lX3MRlyqSJr1QNRLUqR1hP7qr1bKdi88aJO7Ab11LGoFVuITGckNkU0c60QNFFVPsNVDRe 62jZ9aeInVDg== X-IronPort-AV: E=Sophos;i="5.77,404,1596524400"; d="scan'208";a="533870293" Received: from bricha3-mobl.ger.corp.intel.com ([10.214.249.80]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 22 Oct 2020 01:23:03 -0700 Date: Thu, 22 Oct 2020 09:22:57 +0100 From: Bruce Richardson To: David Marchand Cc: dev@dpdk.org, Yipeng Wang , Sameh Gobriel , Pablo de Lara Message-ID: <20201022082257.GD83@bricha3-MOBL.ger.corp.intel.com> References: <20201022075959.19638-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201022075959.19638-1-david.marchand@redhat.com> Subject: Re: [dpdk-dev] [PATCH] hash: use x86 common flag for jhash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 22, 2020 at 09:59:59AM +0200, David Marchand wrote: > jhash has been forgotten when factorising the x86 arch check. > > Fixes: dbf17d44f375 ("hash: use common x86 flag") > > Signed-off-by: David Marchand > --- > lib/librte_hash/rte_jhash.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_hash/rte_jhash.h b/lib/librte_hash/rte_jhash.h > index 7a1eeff74e..f2446f081e 100644 > --- a/lib/librte_hash/rte_jhash.h > +++ b/lib/librte_hash/rte_jhash.h > @@ -91,7 +91,7 @@ __rte_jhash_2hashes(const void *key, uint32_t length, uint32_t *pc, > * Check key alignment. For x86 architecture, first case is always optimal > * If check_align is not set, first case will be used > */ > -#if defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_I686) || defined(RTE_ARCH_X86_X32) > +#if defined(RTE_ARCH_X86) > const uint32_t *k = (const uint32_t *)key; Acked-by: Bruce Richardson