Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4081C388F9 for ; Thu, 22 Oct 2020 17:13:59 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D5AC24630 for ; Thu, 22 Oct 2020 17:13:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D5AC24630 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=m5p.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.10617.28324 (Exim 4.92) (envelope-from ) id 1kVe9s-0003nv-5Y; Thu, 22 Oct 2020 17:13:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 10617.28324; Thu, 22 Oct 2020 17:13:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe9s-0003no-2Z; Thu, 22 Oct 2020 17:13:48 +0000 Received: by outflank-mailman (input) for mailman id 10617; Thu, 22 Oct 2020 17:13:47 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe9r-0003nj-0j for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:13:47 +0000 Received: from mailhost.m5p.com (unknown [74.104.188.4]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8f37ddf2-425e-488f-abae-491b82ac0e9e; Thu, 22 Oct 2020 17:13:44 +0000 (UTC) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.15.2/8.15.2) with ESMTPS id 09MHDSPX081607 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 22 Oct 2020 13:13:34 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.15.2/8.15.2/Submit) id 09MHDS9Z081606; Thu, 22 Oct 2020 10:13:28 -0700 (PDT) (envelope-from ehem) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe9r-0003nj-0j for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:13:47 +0000 X-Inumbo-ID: 8f37ddf2-425e-488f-abae-491b82ac0e9e Received: from mailhost.m5p.com (unknown [74.104.188.4]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8f37ddf2-425e-488f-abae-491b82ac0e9e; Thu, 22 Oct 2020 17:13:44 +0000 (UTC) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.15.2/8.15.2) with ESMTPS id 09MHDSPX081607 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 22 Oct 2020 13:13:34 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.15.2/8.15.2/Submit) id 09MHDS9Z081606; Thu, 22 Oct 2020 10:13:28 -0700 (PDT) (envelope-from ehem) Date: Thu, 22 Oct 2020 10:13:28 -0700 From: Elliott Mitchell To: Jan Beulich Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH] xen/acpi: Don't fail if SPCR table is absent Message-ID: <20201022171328.GA81455@mattapan.m5p.com> References: <20201021221253.GA73207@mattapan.m5p.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Oct 22, 2020 at 09:42:17AM +0200, Jan Beulich wrote: > On 22.10.2020 00:12, Elliott Mitchell wrote: > > --- a/xen/arch/arm/acpi/domain_build.c > > +++ b/xen/arch/arm/acpi/domain_build.c > > @@ -42,17 +42,18 @@ static int __init acpi_iomem_deny_access(struct domain *d) > > status = acpi_get_table(ACPI_SIG_SPCR, 0, > > (struct acpi_table_header **)&spcr); > > > > - if ( ACPI_FAILURE(status) ) > > + if ( ACPI_SUCCESS(status) ) > > { > > - printk("Failed to get SPCR table\n"); > > - return -EINVAL; > > + mfn = spcr->serial_port.address >> PAGE_SHIFT; > > + /* Deny MMIO access for UART */ > > + rc = iomem_deny_access(d, mfn, mfn + 1); > > + if ( rc ) > > + return rc; > > + } > > + else > > + { > > + printk("Failed to get SPCR table, Xen console may be unavailable\n"); > > } > > Nit: While I see you've got Stefano's R-b already, I Xen we typically > omit the braces here. Personally, I prefer that myself, but was unsure of the preference here. I've seen multiple projects which *really* dislike using having brackets for some clauses, but not others (ie they want either all clauses with or all clauses without; instead of only if required). I sent what I thought was the more often used format. (I also like tabs, and dislike having so many spaces; alas my preferences are apparently uncommon) -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445