Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DB34C55178 for ; Wed, 28 Oct 2020 15:38:23 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id C3147247C3 for ; Wed, 28 Oct 2020 15:38:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3147247C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5ACBCC17; Wed, 28 Oct 2020 16:38:20 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 53F9ECBF0; Wed, 28 Oct 2020 16:38:17 +0100 (CET) IronPort-SDR: pwai1NenPwYvq2mSEV9KeCAUw9xKVMYk0SnYVlBNdJkUb/MvL/ZvkraX6RszXDfPtHlqCp/Clm f/8Mp6QUqtMQ== X-IronPort-AV: E=McAfee;i="6000,8403,9788"; a="168377014" X-IronPort-AV: E=Sophos;i="5.77,426,1596524400"; d="scan'208";a="168377014" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2020 08:38:13 -0700 IronPort-SDR: VRCWJl9vKN3pbjp1utXzZAeYD83xMEprzf5wXXNuMV74C/GIP2RUGI0NgkEKOLQE3Wbl1DITdC BsAfvCmPATLA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,426,1596524400"; d="scan'208";a="525155764" Received: from silpixa00400355.ir.intel.com (HELO silpixa00400355.ger.corp.intel.com) ([10.237.223.148]) by fmsmga006.fm.intel.com with ESMTP; 28 Oct 2020 08:38:11 -0700 From: Ciara Power To: dev@dpdk.org Cc: Ciara Power , marko.kovacevic@intel.com, roy.fan.zhang@intel.com, stable@dpdk.org Date: Wed, 28 Oct 2020 15:38:08 +0000 Message-Id: <20201028153808.103328-1-ciara.power@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] examples/fips_validation: fix checking return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The return value was not being checked when calling the get_writeback_data function in the AES test case. On failure, this led to a NULL dereference when using memcpy later. The return value is now checked to avoid this NULL dereference. Coverity issue: 363463 Fixes: cd255ccf5764 ("examples/fips_validation: support AES parsing") Cc: marko.kovacevic@intel.com Cc: roy.fan.zhang@intel.com Cc: stable@dpdk.org Signed-off-by: Ciara Power --- examples/fips_validation/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c index 07532c9562..bc7abd2b8f 100644 --- a/examples/fips_validation/main.c +++ b/examples/fips_validation/main.c @@ -1520,7 +1520,9 @@ fips_mct_aes_test(void) return ret; } - get_writeback_data(&val); + ret = get_writeback_data(&val); + if (ret < 0) + return ret; if (info.op == FIPS_TEST_DEC_AUTH_VERIF) memcpy(prev_in, vec.ct.val, AES_BLOCK_SIZE); -- 2.25.1