Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50FF3C388F7 for ; Wed, 28 Oct 2020 18:14:13 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC1B2247FE for ; Wed, 28 Oct 2020 18:14:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="ejuqCs2C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC1B2247FE Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.13813.34544 (Exim 4.92) (envelope-from ) id 1kXpxH-0004dH-R0; Wed, 28 Oct 2020 18:13:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 13813.34544; Wed, 28 Oct 2020 18:13:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kXpxH-0004dA-Nt; Wed, 28 Oct 2020 18:13:51 +0000 Received: by outflank-mailman (input) for mailman id 13813; Wed, 28 Oct 2020 18:13:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kXpxG-0004d5-5H for xen-devel@lists.xenproject.org; Wed, 28 Oct 2020 18:13:50 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 16e3adbb-f6b6-41cd-860c-2dec95519e15; Wed, 28 Oct 2020 18:13:49 +0000 (UTC) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kXpxG-0004d5-5H for xen-devel@lists.xenproject.org; Wed, 28 Oct 2020 18:13:50 +0000 X-Inumbo-ID: 16e3adbb-f6b6-41cd-860c-2dec95519e15 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 16e3adbb-f6b6-41cd-860c-2dec95519e15; Wed, 28 Oct 2020 18:13:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1603908829; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=iJRY66IfuqDwktqFQFJqHM15N+oXk8Kse5TIrgqQc/w=; b=ejuqCs2C8Ws0WOawEQLOX+bfGA6c8x1eHrxoLVdzPSM4QrWV6Oybfwr/ c9ts+75jXC4wOF+cUgLZYe9JFR890NIjknv0+QqxmlkhwKIOTB74lck/9 mv+0UJpKAKxuPu74uNKClmKHEhdccviQVRTCJ1DzLSb+hl7LdvLrQCm60 o=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: EP5JZDbke5FPw731Eg1l8W+oCE7VrAssW9K+/7chfRPmLOd6M1U4OdmFfdebedk/DUYFQVMtT4 LAt+FolsY0LRCBLFqTu+koHCGnw2hFZXPd0cvoJ4sDS/Wj23onJqojKAs4OR1MD3I5pHczOTxl v3FhKcXatoe13erkiJP2Li9lFK7KR3vTQz2Apkb61zQ1TWGS96iE88qynTGJ5d2X1nAyMQRIWu sbNmvr7wXrbvMwU7Ce6kPJp/T4oSjYgCURfhvFyQEgowBYHi0vHIGxRzpfPtcH99lLVmHnAYaq VN4= X-SBRS: None X-MesageID: 30004285 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.77,427,1596513600"; d="scan'208";a="30004285" Date: Wed, 28 Oct 2020 18:13:44 +0000 From: Anthony PERARD To: Jan Beulich CC: Andrew Cooper , Ian Jackson , Wei Liu , , Olaf Hering Subject: Re: [PATCH v1] libacpi: use temporary files for generated files Message-ID: <20201028181344.GA273696@perard.uk.xensource.com> References: <20201026204151.23459-1-olaf@aepfle.de> <68312718-c8ad-040b-be45-192d2c91ba8f@suse.com> <20201027112703.24d55a50.olaf@aepfle.de> <24025dd2-2c61-7e92-a9b1-2433eea2e909@citrix.com> <3880bcbd-9281-10a5-7de5-f73bcf74557a@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <3880bcbd-9281-10a5-7de5-f73bcf74557a@suse.com> On Tue, Oct 27, 2020 at 12:06:56PM +0100, Jan Beulich wrote: > On 27.10.2020 11:57, Andrew Cooper wrote: > > On 27/10/2020 10:37, Jan Beulich wrote: > >> On 27.10.2020 11:27, Olaf Hering wrote: > >>> Am Tue, 27 Oct 2020 11:16:04 +0100 > >>> schrieb Jan Beulich : > >>> > >>>> This pattern is used when a rule consists of multiple commands > >>>> having their output appended to one another's. > >>> My understanding is: a rule is satisfied as soon as the file exists. > >> No - once make has found that a rule's commands need running, it'll > >> run the full set and only check again afterwards. > > > > It stops at the first command which fails. > > > > Olaf is correct, but the problem here is an incremental build issue, not > > a parallel build issue. > > > > Intermediate files must not use the name of the target, or a failure and > > re-build will use the (bogus) intermediate state rather than rebuilding it. > > But there's no intermediate file here - the file gets created in one > go. Furthermore doesn't make delete the target file(s) when a rule > fails? (One may not want to rely on this, and hence indeed keep multi- > part rules update intermediate files of different names.) What if something went badly enough and sed didn't managed to write the whole file and make never had a chance to remove the bogus file? Surely, this patch is a strict improvement to the build system. Cheers, -- Anthony PERARD