From: Peter Zijlstra Date: Thu, 29 Oct 2020 12:04:42 +0000 Subject: Re: [PATCH] x86/unwind: remove unneeded initialization Message-Id: <20201029120442.GP2628@hirez.programming.kicks-ass.net> List-Id: References: <20201028122102.24202-1-lukas.bulwahn@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Walter Harms Cc: Lukas Bulwahn , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Josh Poimboeuf , "x86@kernel.org" , "H . Peter Anvin" , Nathan Chancellor , Nick Desaulniers , "linux-kernel@vger.kernel.org" , "clang-built-linux@googlegroups.com" , "kernel-janitors@vger.kernel.org" , "linux-safety@lists.elisa.tech" On Thu, Oct 29, 2020 at 11:49:50AM +0000, Walter Harms wrote: > this looks like a reimplementation of bsearch() > perhaps the maintainer can add a comment why the > kernel implementation is not suitable here ? If you look carefully it doesn't do an exact match, which is what bsearch() does. bsearch() also isn't stable in the precense of duplicates.