X-GM-THRID: 6889248551394607104 X-Received: by 2002:a05:6808:6c8:: with SMTP id m8mr1461813oih.36.1604062554389; Fri, 30 Oct 2020 05:55:54 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 2002:a05:6830:20cb:: with SMTP id z11ls1582099otq.9.gmail; Fri, 30 Oct 2020 05:55:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzLEQSeo2HgeKjGAo0rf3p5tHiJqoNuQaW+rN2KDaTKj+a7TUAwrORc5xHp76MNoVCJwxI X-Received: by 2002:a05:6830:124b:: with SMTP id s11mr1299913otp.316.1604062553308; Fri, 30 Oct 2020 05:55:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1604062553; cv=none; d=google.com; s=arc-20160816; b=E084BheaScEJesH9iMrCC+wwEgKO3gZvJ1PmsNyUzRFwwzuzm8A1WJxEq9F1BVndwq lweYeG6lqc0rmWvnFmrVhPzOK0UgXfSDrt8mH1GlK07RaBTgKj6KcSznT5fVSY9ezjo7 IJ9qOXiiZT5Tl3KLvAYssk9lp3ngWhAAKPkLALP5X6E8jSkDvTGuDSWrBrzNHMAtDwvz xE33eCV8RWesHAw1hgbpf/TaRE0kH7a54a87kANM6cp6lQhF1zRG2bn7ajN5LzLVNE18 SJufDwWaFKgdKlEpNLxNNhTuuwdw3ciAhymSeaYwnXXoRBDUEv8NtzgCRnRsdniWbprx 684g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=EY5jmWEppGIZD3OkVY+PrUIlVBuLQJBSLFzS0cv2zkM=; b=mTnMg5s1Ta7kZKQvZA5xE0cTbndmP4z3xd4MtMOlSUExNoIu80XlbM2iu4ZajJFrwU xUidnS3EnQ7d43bgqAh/K6L0yehUvCy4fFqtydgfYhuN4TTqXMhFAnCEB5eEOypL43Yd 3w4F2iAJGBMDrdzhH1sNS0l4Q9MPokmSeWClhWiuvXTvsSQn46Fmehg7GSSPPgBzDCuc 8eBYVSXQV/iUgW52sg7PdOTFEpR7O539fo5eYctnhVUTQWLkztVYPFqvxsr/5qZB9eD5 0q/M9UYwjyWahVSPrah7xvDawk4aaOi4B5ePeti7999c1aBjaYiYo/Mc/c9+DE5vUvyK YB9w== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=WgQp7Qji; spf=pass (google.com: domain of mh12gx2825@gmail.com designates 2607:f8b0:4864:20::541 as permitted sender) smtp.mailfrom=mh12gx2825@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com. [2607:f8b0:4864:20::541]) by gmr-mx.google.com with ESMTPS id w26si386843oih.1.2020.10.30.05.55.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Oct 2020 05:55:53 -0700 (PDT) Received-SPF: pass (google.com: domain of mh12gx2825@gmail.com designates 2607:f8b0:4864:20::541 as permitted sender) client-ip=2607:f8b0:4864:20::541; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=WgQp7Qji; spf=pass (google.com: domain of mh12gx2825@gmail.com designates 2607:f8b0:4864:20::541 as permitted sender) smtp.mailfrom=mh12gx2825@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-pg1-x541.google.com with SMTP id z24so5141579pgk.3 for ; Fri, 30 Oct 2020 05:55:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=EY5jmWEppGIZD3OkVY+PrUIlVBuLQJBSLFzS0cv2zkM=; b=WgQp7Qjiipq8bte2F1/XmxDPy678VMaI9Ka5i4CJlLM1plIBKrrKgJM3nLT34PINBr WQqbuvEeg3MK45EaLtALAiEFpwYzprg/RILN3PrXmHXJw+muwSjEQb96/fU5VB4f2aIx F5Dc0u6qNHTOwdeyVq4EuGaO311NqjR1yN4CzUH9vwhcJ1i8BWtCyMTDFAAku5fV0+AR ohvpHctMTeVrBOpe6ZOnao1AWQCz9Wxl64XuYx1ivWMi6e/weY8eQ38/voa3ATTB7w5v i4RqN64uuTgCOCNOQYLDNr6/g4Tz8x6axhvES1vtSHJfiabDIELHfktcq8S/dEad9nlV rY5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=EY5jmWEppGIZD3OkVY+PrUIlVBuLQJBSLFzS0cv2zkM=; b=Rf9k6+wiI8oeQ9wXS96idEOjyNC/4rGokg5HAl6/GMjT1NnBjS1Hi+QlN0xeB3E2LB MUmA5XZiejBDKRpGSCvvdoHBZ/xzdI7QJCMh26CcDUPfteuD8bjPl1wG43Hl80d//Rtr pDW3Xj+4SP4d4ELVq9pIJrCFGY9wQETiWQLzZWmVlqp6pKnmIg4KdIVyuPXqOlplQ+ds Gb4LvaZGVQMxY3A9N3igI/1pfMlmXB06yJMWWcBojw0/Ou5OoDBzjOE1z4Y0DSKKNf42 qE88Auc6J7blVHeFiyrfijyEFn0YKtxd8zdmjdyz7uCgflCOZhOvofh61pCd9AdvgD0Z H0lw== X-Gm-Message-State: AOAM5318RKlVyfSazW/DRWHXnINwIn/IIeuNctK+2BHNihYRmx+0IBSw 2/QPE7dLw+eZ2Pesj/ChAl0= X-Received: by 2002:a17:90a:fa09:: with SMTP id cm9mr2840218pjb.162.1604062552599; Fri, 30 Oct 2020 05:55:52 -0700 (PDT) Return-Path: Received: from my--box ([103.98.79.70]) by smtp.gmail.com with ESMTPSA id w19sm6220886pff.6.2020.10.30.05.55.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Oct 2020 05:55:52 -0700 (PDT) Date: Fri, 30 Oct 2020 18:25:45 +0530 From: Deepak R Varma To: Greg KH , Christian =?iso-8859-1?Q?K=F6nig?= , outreachy-kernel@googlegroups.com, Alex Deucher , David Airlie , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, melissa.srw@gmail.com Cc: mh12gx2825@gmail.com Subject: Re: [Outreachy kernel] [PATCH] drm/amdgpu: use DEFINE_DEBUGFS_ATTRIBUTE with debugfs_create_file_unsafe() Message-ID: <20201030125545.GA12671@my--box> References: <20201030032245.GA274478@my--box> <20201030071120.GA1493629@kroah.com> <20201030075716.GA6976@my--box> <5a7d8e8d-8db5-ff56-6448-3f1cefc11ef8@amd.com> <20201030082518.GB1619669@kroah.com> <20201030091521.GH401619@phenom.ffwll.local> <20201030092457.GI401619@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201030092457.GI401619@phenom.ffwll.local> On Fri, Oct 30, 2020 at 10:24:57AM +0100, Daniel Vetter wrote: > On Fri, Oct 30, 2020 at 10:15:21AM +0100, Daniel Vetter wrote: > > On Fri, Oct 30, 2020 at 09:25:18AM +0100, Greg KH wrote: > > > On Fri, Oct 30, 2020 at 09:00:04AM +0100, Christian K�nig wrote: > > > > Am 30.10.20 um 08:57 schrieb Deepak R Varma: > > > > > On Fri, Oct 30, 2020 at 08:11:20AM +0100, Greg KH wrote: > > > > > > On Fri, Oct 30, 2020 at 08:52:45AM +0530, Deepak R Varma wrote: > > > > > > > Using DEFINE_DEBUGFS_ATTRIBUTE macro with debugfs_create_file_unsafe() > > > > > > > function in place of the debugfs_create_file() function will make the > > > > > > > file operation struct "reset" aware of the file's lifetime. Additional > > > > > > > details here: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.archive.carbon60.com%2Flinux%2Fkernel%2F2369498&data=04%7C01%7Cchristian.koenig%40amd.com%7Cddd7a6ac8164415a639708d87ca97004%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637396414464384011%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=o6GOHvMxNMuOPlC4nhDyURCHBLqfQZhYQq%2BiIMt3D3s%3D&reserved=0 > > > > > > > > > > > > > > Issue reported by Coccinelle script: > > > > > > > scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci > > > > > > > > > > > > > > Signed-off-by: Deepak R Varma > > > > > > > --- > > > > > > > Please Note: This is a Outreachy project task patch. > > > > > > > > > > > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 20 ++++++++++---------- > > > > > > > 1 file changed, 10 insertions(+), 10 deletions(-) > > > > > > > > > > > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c > > > > > > > index 2d125b8b15ee..f076b1ba7319 100644 > > > > > > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c > > > > > > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c > > > > > > > @@ -1551,29 +1551,29 @@ static int amdgpu_debugfs_sclk_set(void *data, u64 val) > > > > > > > return 0; > > > > > > > } > > > > > > > -DEFINE_SIMPLE_ATTRIBUTE(fops_ib_preempt, NULL, > > > > > > > - amdgpu_debugfs_ib_preempt, "%llu\n"); > > > > > > > +DEFINE_DEBUGFS_ATTRIBUTE(fops_ib_preempt, NULL, > > > > > > > + amdgpu_debugfs_ib_preempt, "%llu\n"); > > > > > > Are you sure this is ok? Do these devices need this additional > > > > > > "protection"? Do they have the problem that these macros were written > > > > > > for? > > > > > > > > > > > > Same for the other patches you just submitted here, I think you need to > > > > > > somehow "prove" that these changes are necessary, checkpatch isn't able > > > > > > to determine this all the time. > > > > > Hi Greg, > > > > > Based on my understanding, the current function debugfs_create_file() > > > > > adds an overhead of lifetime managing proxy for such fop structs. This > > > > > should be applicable to these set of drivers as well. Hence I think this > > > > > change will be useful. > > > > > > > > Well since this is only created once per device instance I don't really care > > > > about this little overhead. > > > > > > > > But what exactly is debugfs doing or not doing here? > > > > > > It is trying to save drivers from having debugfs files open that point > > > to memory that can go away at any time. For graphics devices, I doubt > > > that is the case. > > > > So for anything we add/remove we have two-stage cleanup > > > > 1. drm_dev_unregister (or drm_connector_unregisters, those are the only > > two hotunpluggable things we have) unregister all the uapi interfaces. > > This deletes all the sysfs and debugfs files. > > > > 2. Once all the references to the underlying object disappear from the > > kernel, we free up the data structure. > > > > Now for chardev and similar uapi, we hold full references for open files. > > But for sysfs and debugfs we assume that those uapi layers will make sure > > that after we deleted the files in step 1 all access through these > > functions are guaranteed to have finished. If that's not the case, then we > > need to rework our refcounting and also refcount the underlying drm > > structure (drm_device or drm_connector) from sysfs/debugfs files. > > > > Now I tried to look at the patch Deepak references, and I'm not really > > clear what changes. Or whether we made a wrong assumption previously about > > what debugfs/sysfs guarantee when we delete the files. > > I read some more code and kerneldoc, and I still have no idea what this > new _unsafe variant is used for. Only ones I've found seem to use > debugfs_file_get/put like the normal variant, to protect against > concurrently removed files due to hotunplug. Which is kinda what we've > been expecting debugfs to do for us. > > What's a use-case for _unsafe _without_ debugfs_file_get/put? > > Decently confused me over here doesn't get this. > -Daniel Hi All, Thank you for your comments. I was not anticipating this to be such a offbeat patch. Pardon my growing understanding. Please suggest if I can evaluate the change proposed to confirm if this is a meaningful change. Thank you again! ./drv > > > -Daniel > > > > > > > > thanks, > > > > > > greg k-h > > > > -- > > Daniel Vetter > > Software Engineer, Intel Corporation > > http://blog.ffwll.ch > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch