Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kZvhJ-0001JD-F1 for mharc-qemu-trivial@gnu.org; Tue, 03 Nov 2020 07:46:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZvhH-0001Hl-Ih for qemu-trivial@nongnu.org; Tue, 03 Nov 2020 07:46:00 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:23648) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kZvhE-0000Ba-LP for qemu-trivial@nongnu.org; Tue, 03 Nov 2020 07:45:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604407555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=101Z4WjXpexM5SP/r/4mDlx2TOuUwf2hqamk6tgW5ao=; b=MNNb8gVMy590/vRSAtPlnVlBM817vjRfPavR1kmfZifHP264xyICnqrIQShqa9tu8I2Q00 sSnctIjzP+/+N1+sVz4QB4eymUTg6QIjcOKhuZiJt9lf2vP9aHEq0JONdYfkEUrZqp9Aas yIg9ilqUv+Tk5chLp/8rRuAELVafa94= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-74-JMvsyLd1NSiYSGsDIJSruA-1; Tue, 03 Nov 2020 07:45:54 -0500 X-MC-Unique: JMvsyLd1NSiYSGsDIJSruA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 934DA1868414; Tue, 3 Nov 2020 12:45:52 +0000 (UTC) Received: from work-vm (ovpn-115-84.ams2.redhat.com [10.36.115.84]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3B98510013C1; Tue, 3 Nov 2020 12:45:47 +0000 (UTC) Date: Tue, 3 Nov 2020 12:45:44 +0000 From: "Dr. David Alan Gilbert" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, Juan Quintela , qemu-ppc@nongnu.org, Laurent Vivier , David Gibson , Gerd Hoffmann , Dov Murik , qemu-trivial@nongnu.org, Michael Tokarev Subject: Re: [PATCH-for-5.2 2/4] hw/display/cirrus_vga: Fix hexadecimal format string specifier Message-ID: <20201103124544.GF3566@work-vm> References: <20201103112558.2554390-1-philmd@redhat.com> <20201103112558.2554390-3-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: <20201103112558.2554390-3-philmd@redhat.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/03 01:02:05 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2020 12:46:00 -0000 * Philippe Mathieu-Daudé (philmd@redhat.com) wrote: > The '%u' conversion specifier is for decimal notation. > When prefixing a format with '0x', we want the hexadecimal > specifier ('%x'). > > Inspired-by: Dov Murik > Signed-off-by: Philippe Mathieu-Daudé Oh that's nice, one my regex wouldn't find. Reviewed-by: Dr. David Alan Gilbert > --- > hw/display/cirrus_vga.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c > index e14096deb46..fdca6ca659f 100644 > --- a/hw/display/cirrus_vga.c > +++ b/hw/display/cirrus_vga.c > @@ -2105,7 +2105,7 @@ static void cirrus_vga_mem_write(void *opaque, > } else { > qemu_log_mask(LOG_GUEST_ERROR, > "cirrus: mem_writeb 0x" TARGET_FMT_plx " " > - "value 0x%02" PRIu64 "\n", addr, mem_value); > + "value 0x%02" PRIx64 "\n", addr, mem_value); > } > } > > -- > 2.26.2 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK