Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C846C2D0A3 for ; Wed, 4 Nov 2020 14:17:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1798D221E2 for ; Wed, 4 Nov 2020 14:17:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m/v/u45M" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1798D221E2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=karo-electronics.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=03Lhba/P5YoH3tERjwJoA/V0YRct3FtdY1hntLSbuKo=; b=m/v/u45MZYwLO1u0DWiIE7pWP2 X+HNcb6wg82rw4kbbU5Z8oAjLmakSgy9mIgdWUp9onc/8wrtVwzo0VlPV0chaEDsRh2096VS4fwBX VISFlycJYMuK6rUnswYVaEbQzz3z5fEpkBzAq8/PpspnbC5Q94gDI6hzqG6C7O97WYDDFuHM7QuaP OK5NCoFuBQZG9bBRldVKyAQKEUNOmrR8nS/3+UYKMnX6ZMsOFjQNGBOO+t6yj6CTBWmesHhJfwPye RVviSPqteSH9dLzO4p3w6ZSiB92PPBnCaJTcCycjU0juUVHIHiNOnsNxVZcRhfuwa1F4PEUZsxkcP m7sP3viA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaJa3-0001n8-Ee; Wed, 04 Nov 2020 14:16:07 +0000 Received: from smtprelay02.ispgateway.de ([80.67.29.24]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaJZz-0001lj-Uo for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 14:16:04 +0000 Received: from [89.1.81.74] (helo=mb-ubuntu.Ka-Ro.local) by smtprelay02.ispgateway.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.3) (envelope-from ) id 1kaJVT-0000qC-4I; Wed, 04 Nov 2020 15:11:23 +0100 From: Markus Bauer To: Subject: [PATCH] net: stmmac: Don't log error message in case of -EPROBE_DEFER. Date: Wed, 4 Nov 2020 15:15:24 +0100 Message-Id: <20201104141524.13044-1-mb@karo-electronics.de> X-Mailer: git-send-email 2.17.1 X-Df-Sender: bWJAa2Fyby1lbGVjdHJvbmljcy5kb21haW5mYWN0b3J5LWt1bmRlLmRl X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_091604_006938_183970CB X-CRM114-Status: GOOD ( 12.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Torgue , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Jose Abreu , Maxime Coquelin , Giuseppe Cavallaro , "David S . Miller" , linux-arm-kernel@lists.infradead.org, Markus Bauer MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Remove error messages that might confuse users when error is just -517 / -EPROBE_DEFER. [...] imx-dwmac 30bf0000.ethernet: Cannot register the MDIO bus imx-dwmac 30bf0000.ethernet: stmmac_dvr_probe: MDIO bus (id: 0) registration failed [...] --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 7 ++++--- drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 6 ++++-- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 33272a12989a..7d1cdd576b91 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -4857,9 +4857,10 @@ int stmmac_dvr_probe(struct device *device, /* MDIO bus Registration */ ret = stmmac_mdio_register(ndev); if (ret < 0) { - dev_err(priv->device, - "%s: MDIO bus (id: %d) registration failed", - __func__, priv->plat->bus_id); + if (ret != -EPROBE_DEFER) + dev_err(priv->device, + "%s: MDIO bus (id: %d) registration failed, err=%d", + __func__, priv->plat->bus_id, ret); goto error_mdio_register; } } diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c index 226e5a4bf21c..8e202f63da31 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c @@ -401,8 +401,10 @@ int stmmac_mdio_register(struct net_device *ndev) new_bus->parent = priv->device; err = of_mdiobus_register(new_bus, mdio_node); - if (err != 0) { - dev_err(dev, "Cannot register the MDIO bus\n"); + if (err) { + if (err != -EPROBE_DEFER) + dev_err(dev, + "Cannot register the MDIO bus, err=%d\n", err); goto bus_register_fail; } -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel