Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FA95C4741F for ; Thu, 5 Nov 2020 15:04:05 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D058221D81 for ; Thu, 5 Nov 2020 15:04:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="TlulDo0H"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="pi1bUtS/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D058221D81 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 027BA1673; Thu, 5 Nov 2020 16:03:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 027BA1673 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1604588640; bh=k8FY8nKjBeutJ6Xavr7PcVjJvuWQDn7jxITLi1s4w50=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=TlulDo0HFt48fiFg4FCbwprP8U2Oiinxu+KqGF6JjpA9tFdpo3GUVGQAJjtSF136T 7LvqY+JULWHtXQ4gx1IIWqbnKeBZXf6O2HBLlC/44udy4Hyp+qJLu+BY1TxBHjnnVb wpx+hRarvvGQHZwQ0DHpyoEdH/uHuckxcO39niR0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7AB97F800BA; Thu, 5 Nov 2020 16:03:09 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 12326F80171; Thu, 5 Nov 2020 16:03:08 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F35BEF800BA for ; Thu, 5 Nov 2020 16:03:04 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F35BEF800BA Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="pi1bUtS/" Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A24B3206D9; Thu, 5 Nov 2020 15:03:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604588581; bh=k8FY8nKjBeutJ6Xavr7PcVjJvuWQDn7jxITLi1s4w50=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pi1bUtS/+nDH1FEx9Sjvxw+roiQlaVFikFD7XEFv2z0c3o2akid1wV6YtZ3v1MSEt ojHlzh7AeI89CkNl9K7kSBuY7OneSv/qsXh8xMr0UrV2r8IXPihIoJZJ1j3xVr2Bvv HMNXcIHdk6LeJYjfoBLs6XwEAIuyoeBU2AGjDwTQ= Date: Thu, 5 Nov 2020 15:02:49 +0000 From: Mark Brown To: Tzung-Bi Shih Subject: Re: [PATCH] ASoC: nau8315: add codec driver Message-ID: <20201105150249.GC4856@sirena.org.uk> References: <20201102023212.594137-1-CTLIN0@nuvoton.com> <0adb99c2-d0d9-5052-c163-4d9a341239fc@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LwW0XdcUbUexiWVK" Content-Disposition: inline In-Reply-To: X-Cookie: It's the thought, if any, that counts! User-Agent: Mutt/1.10.1 (2018-07-13) Cc: ALSA development , WTLI@nuvoton.com, KCHSU0@nuvoton.com, Pierre-Louis Bossart , Liam Girdwood , YHCHuang@nuvoton.com, CTLIN0 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --LwW0XdcUbUexiWVK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 05, 2020 at 10:20:33AM +0800, Tzung-Bi Shih wrote: > If nau8315 doesn't share I2S with other components for now, it could > be better to not introduce the software mute control. The mute callback is there because there's some controllers that don't start up cleanly and end up outputing glitches (for example due to not being able to flush their FIFOs) - keeping the CODEC muted until after the I2S is running covers those glitches. --LwW0XdcUbUexiWVK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl+kFBgACgkQJNaLcl1U h9CIBAf+K4PhEQViuI18TXdqBVYXq5P8w9MpEiCR5NcYmkffqTe/ym/V5oXqTVYJ U5DOiTM3V9nco9Ad7Ql3FFssibvrVy0ppS15BrEh7H3GAoxFy8e2bcfNlqyldMjb flXpwJmW1RgTg0EJ38qHZeMgJt4d+jsQOGS1lV7GLZYtq0cm1k2HfRmIy9Z0p1YC x6p2oY+EDbKCSESS7t65D/XUAmaogIUBGdUKaS79/Iehyf81HXZsMrYfmRE0pGAF tfEOhaHRxg6rL1lOB17SpFf1v0xtgUPbusNV+QYGpM/4ZWGY/ef8MopiD4qJnjY8 83sAsRzpI01yG04A2fzteYI+O4Bt5w== =as/c -----END PGP SIGNATURE----- --LwW0XdcUbUexiWVK--