Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id AA2A46EA6F for ; Fri, 6 Nov 2020 08:30:05 +0000 (UTC) From: Thomas Zimmermann Date: Fri, 6 Nov 2020 09:29:55 +0100 Message-Id: <20201106082955.8939-9-tzimmermann@suse.de> In-Reply-To: <20201106082955.8939-1-tzimmermann@suse.de> References: <20201106082955.8939-1-tzimmermann@suse.de> MIME-Version: 1.0 Subject: [igt-dev] [PATCH v2 8/8] tests/fbdev: Add tests for read/writing with NULL-pointer buffers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: daniel.vetter@ffwll.ch, chris@chris-wilson.co.uk, petri.latvala@intel.com Cc: igt-dev@lists.freedesktop.org, Thomas Zimmermann List-ID: Trying to read and write with a NULL-pointer buffer should fail and report EFAULT. Signed-off-by: Thomas Zimmermann --- tests/fbdev.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/tests/fbdev.c b/tests/fbdev.c index 5b7086d1..6e279415 100644 --- a/tests/fbdev.c +++ b/tests/fbdev.c @@ -235,6 +235,18 @@ static void framebuffer_tests(int fd) igt_require_f(ret == 0, "read at EOF, ret=%zd\n", ret); } + igt_subtest("nullptr") { + ssize_t ret; + + igt_describe("Check framebuffer access with NULL"); + + ret = pread(fd, NULL, fix_info.smem_len, 0); + igt_require_f((ret == -1) && (errno == EFAULT), "reading into NULL did not return EFAULT, ret=%zd\n", ret); + + ret = pwrite(fd, NULL, fix_info.smem_len, 0); + igt_require_f((ret == -1) && (errno == EFAULT), "writing from NULL did not return EFAULT, ret=%zd\n", ret); + } + igt_fixture { free(buf); memset(map, 0, fix_info.smem_len); // don't leave garbage on the screen -- 2.29.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev