Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23401C388F7 for ; Sat, 7 Nov 2020 07:57:38 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B01E220704 for ; Sat, 7 Nov 2020 07:57:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B01E220704 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.21283.47597 (Exim 4.92) (envelope-from ) id 1kbJ5y-0004yJ-2N; Sat, 07 Nov 2020 07:57:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 21283.47597; Sat, 07 Nov 2020 07:57:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kbJ5x-0004yC-VH; Sat, 07 Nov 2020 07:57:09 +0000 Received: by outflank-mailman (input) for mailman id 21283; Sat, 07 Nov 2020 07:57:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kbJ5w-0004y7-6x for xen-devel@lists.xenproject.org; Sat, 07 Nov 2020 07:57:08 +0000 Received: from deinos.phlegethon.org (unknown [2001:41d0:8:b1d7::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4d56b3fd-c204-4139-ae8b-ebad8c81c9a5; Sat, 07 Nov 2020 07:57:07 +0000 (UTC) Received: from tjd by deinos.phlegethon.org with local (Exim 4.92.3 (FreeBSD)) (envelope-from ) id 1kbJ5s-0002w8-9C; Sat, 07 Nov 2020 07:57:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kbJ5w-0004y7-6x for xen-devel@lists.xenproject.org; Sat, 07 Nov 2020 07:57:08 +0000 X-Inumbo-ID: 4d56b3fd-c204-4139-ae8b-ebad8c81c9a5 Received: from deinos.phlegethon.org (unknown [2001:41d0:8:b1d7::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4d56b3fd-c204-4139-ae8b-ebad8c81c9a5; Sat, 07 Nov 2020 07:57:07 +0000 (UTC) Received: from tjd by deinos.phlegethon.org with local (Exim 4.92.3 (FreeBSD)) (envelope-from ) id 1kbJ5s-0002w8-9C; Sat, 07 Nov 2020 07:57:04 +0000 Date: Sat, 7 Nov 2020 07:57:04 +0000 From: Tim Deegan To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , George Dunlap Subject: Re: [PATCH v2 7/9] x86/p2m: pass old PTE directly to write_p2m_entry_pre() hook Message-ID: <20201107075704.GA11151@deinos.phlegethon.org> References: <4b63025f-164c-2e93-3d54-7a7f145ad046@suse.com> <9d10a4be-e463-0d3d-39c0-0920761537c5@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <9d10a4be-e463-0d3d-39c0-0920761537c5@suse.com> X-SA-Known-Good: Yes X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tim@xen.org X-SA-Exim-Scanned: No (on deinos.phlegethon.org); SAEximRunCond expanded to false At 10:38 +0100 on 06 Nov (1604659085), Jan Beulich wrote: > In no case is a pointer to non-const needed. Since no pointer arithmetic > is done by the sole user of the hook, passing in the PTE itself is quite > fine. > > While doing this adjustment also > - drop the intermediate sh_write_p2m_entry_pre(): > sh_unshadow_for_p2m_change() can itself be used as the hook function, > moving the conditional into there, > - introduce a local variable holding the flags of the old entry. > > Signed-off-by: Jan Beulich Acked-by: Tim Deegan