Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB31CC388F7 for ; Sat, 7 Nov 2020 07:58:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88FF520704 for ; Sat, 7 Nov 2020 07:58:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="Va7y/snB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727873AbgKGH6X (ORCPT ); Sat, 7 Nov 2020 02:58:23 -0500 Received: from m42-4.mailgun.net ([69.72.42.4]:41382 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727242AbgKGH6X (ORCPT ); Sat, 7 Nov 2020 02:58:23 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1604735903; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=axbsOwzKBr/tCGr4UO3qcJHBXV7tZ4hWQauKDhavazA=; b=Va7y/snBoi4BG6W5O3g4cmzY8cnan4DwvYI4l9912eXINQ/JXf5KQOzFqrIDgmB1XmNNs9iE IY+ZID/5U+rg8/Mt8CP9IJa3zzgu6xkY/hNyNVG3dVxv8oWmpsfaOwT2upaivXg3LCpHuW/g A+Q1xIN5LcfM6iXGbYtTggVaD/E= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 5fa6539d02f4ee3801b105fa (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 07 Nov 2020 07:58:21 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 857D6C433C9; Sat, 7 Nov 2020 07:58:20 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 27632C433C8; Sat, 7 Nov 2020 07:58:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 27632C433C8 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath10k: cancel rx worker in hif_stop for SDIO From: Kalle Valo In-Reply-To: <1604558036-4056-1-git-send-email-wgong@codeaurora.org> References: <1604558036-4056-1-git-send-email-wgong@codeaurora.org> To: Wen Gong Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, wgong@codeaurora.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20201107075820.857D6C433C9@smtp.codeaurora.org> Date: Sat, 7 Nov 2020 07:58:20 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Wen Gong wrote: > The rx worker of SDIO should be cancelled after disable interrupt, and > release rx sk_buff in queue, otherwise the rx worker maybe still run > after hif_stop. And it should be cancelled before napi_synchronize in > hif_stop, because the rx worker of SDIO will call napi_schedule, it > should have no napi_schedule before napi_synchronize, otherwise it > lead napi_synchronize wait untill napi_complete. > > Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00049 > > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 9501bc2b16b5 ath10k: cancel rx worker in hif_stop for SDIO -- https://patchwork.kernel.org/project/linux-wireless/patch/1604558036-4056-1-git-send-email-wgong@codeaurora.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches