Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C25BC388F7 for ; Fri, 13 Nov 2020 11:24:28 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7FAD22240 for ; Fri, 13 Nov 2020 11:24:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="d+fPLQPe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7FAD22240 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.26390.54711 (Exim 4.92) (envelope-from ) id 1kdXBh-0000Ck-AE; Fri, 13 Nov 2020 11:24:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 26390.54711; Fri, 13 Nov 2020 11:24:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kdXBh-0000Cd-6j; Fri, 13 Nov 2020 11:24:17 +0000 Received: by outflank-mailman (input) for mailman id 26390; Fri, 13 Nov 2020 11:24:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kdXBf-0000CX-TC for xen-devel@lists.xenproject.org; Fri, 13 Nov 2020 11:24:16 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [63.128.21.124]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id aebf0d58-04c0-4030-87a6-f9a2267f90b0; Fri, 13 Nov 2020 11:24:15 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-428-_EGJdfxvP22jC5B0pSvw3w-1; Fri, 13 Nov 2020 06:24:10 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BA9515F9D1; Fri, 13 Nov 2020 11:24:08 +0000 (UTC) Received: from gondolin (ovpn-113-133.ams2.redhat.com [10.36.113.133]) by smtp.corp.redhat.com (Postfix) with ESMTP id A47C15B4B0; Fri, 13 Nov 2020 11:23:54 +0000 (UTC) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kdXBf-0000CX-TC for xen-devel@lists.xenproject.org; Fri, 13 Nov 2020 11:24:16 +0000 X-Inumbo-ID: aebf0d58-04c0-4030-87a6-f9a2267f90b0 Received: from us-smtp-delivery-124.mimecast.com (unknown [63.128.21.124]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id aebf0d58-04c0-4030-87a6-f9a2267f90b0; Fri, 13 Nov 2020 11:24:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605266654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8n4tiXp+8mrteg2gUVfjQLr91gUwx8183hlKQTpBrkk=; b=d+fPLQPeO0NAYE81+Dqs4gYOtDCNBCCBbtXIGZC9ISS9YBuTcrvI0VoDPiBUakCihPU5th w4uDsSHH6Q8DmhAj34ZoyUGyhIJby/1A2wFHvcRRVAgwtswsmHK1kHc19VWaM5k/JuJuIx vL9XVFZcG7KxnBdoLyOrW3JOKAgk3jQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-428-_EGJdfxvP22jC5B0pSvw3w-1; Fri, 13 Nov 2020 06:24:10 -0500 X-MC-Unique: _EGJdfxvP22jC5B0pSvw3w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BA9515F9D1; Fri, 13 Nov 2020 11:24:08 +0000 (UTC) Received: from gondolin (ovpn-113-133.ams2.redhat.com [10.36.113.133]) by smtp.corp.redhat.com (Postfix) with ESMTP id A47C15B4B0; Fri, 13 Nov 2020 11:23:54 +0000 (UTC) Date: Fri, 13 Nov 2020 12:23:51 +0100 From: Cornelia Huck To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Igor Mammedov , Markus Armbruster , Kevin Wolf , "Daniel P. Berrange" , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , Paolo Bonzini , Eric Blake , John Snow , Stefan Berger , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , Stefan Berger , Stefano Stabellini , Anthony Perard , Paul Durrant , Max Reitz , Thomas Huth , Richard Henderson , David Hildenbrand , Halil Pasic , Christian Borntraeger , Matthew Rosato , Alex Williamson , xen-devel@lists.xenproject.org, qemu-block@nongnu.org, qemu-s390x@nongnu.org Subject: Re: [PATCH v3 09/53] qdev: Make qdev_get_prop_ptr() get Object* arg Message-ID: <20201113122351.583f53a2.cohuck@redhat.com> In-Reply-To: <20201112214350.872250-10-ehabkost@redhat.com> References: <20201112214350.872250-1-ehabkost@redhat.com> <20201112214350.872250-10-ehabkost@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 12 Nov 2020 16:43:06 -0500 Eduardo Habkost wrote: > Make the code more generic and not specific to TYPE_DEVICE. >=20 > Reviewed-by: Marc-Andr=C3=A9 Lureau > Signed-off-by: Eduardo Habkost > --- > Changes v1 -> v2: > - Fix build error with CONFIG_XEN > I took the liberty of keeping the Reviewed-by line from > Marc-Andr=C3=A9 as the build fix is a trivial one line change > --- > Cc: Stefan Berger > Cc: Stefano Stabellini > Cc: Anthony Perard > Cc: Paul Durrant > Cc: Kevin Wolf > Cc: Max Reitz > Cc: Paolo Bonzini > Cc: "Daniel P. Berrang=C3=A9" > Cc: Eduardo Habkost > Cc: Cornelia Huck > Cc: Thomas Huth > Cc: Richard Henderson > Cc: David Hildenbrand > Cc: Halil Pasic > Cc: Christian Borntraeger > Cc: Matthew Rosato > Cc: Alex Williamson > Cc: qemu-devel@nongnu.org > Cc: xen-devel@lists.xenproject.org > Cc: qemu-block@nongnu.org > Cc: qemu-s390x@nongnu.org > --- > include/hw/qdev-properties.h | 2 +- > backends/tpm/tpm_util.c | 8 ++-- > hw/block/xen-block.c | 5 +- > hw/core/qdev-properties-system.c | 57 +++++++++------------- > hw/core/qdev-properties.c | 82 +++++++++++++------------------- > hw/s390x/css.c | 5 +- > hw/s390x/s390-pci-bus.c | 4 +- > hw/vfio/pci-quirks.c | 5 +- > 8 files changed, 68 insertions(+), 100 deletions(-) Reviewed-by: Cornelia Huck #s390 parts