Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B726C4742C for ; Fri, 13 Nov 2020 22:01:50 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE7F820B80 for ; Fri, 13 Nov 2020 22:01:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE7F820B80 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lwn.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 3C050879E0; Fri, 13 Nov 2020 22:01:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N3MCsMPkZPkp; Fri, 13 Nov 2020 22:01:48 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 75A9F879D9; Fri, 13 Nov 2020 22:01:48 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5314EC088E; Fri, 13 Nov 2020 22:01:48 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id B7618C0800 for ; Fri, 13 Nov 2020 22:01:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 9D4838779F for ; Fri, 13 Nov 2020 22:01:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 23zt4HyTinw6 for ; Fri, 13 Nov 2020 22:01:46 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from ms.lwn.net (ms.lwn.net [45.79.88.28]) by whitealder.osuosl.org (Postfix) with ESMTPS id 0A7DF8778D for ; Fri, 13 Nov 2020 22:01:45 +0000 (UTC) Received: from lwn.net (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 24FB94FA; Fri, 13 Nov 2020 22:01:45 +0000 (UTC) Date: Fri, 13 Nov 2020 15:01:44 -0700 From: Jonathan Corbet To: Aditya Srivastava Message-ID: <20201113150144.11316c0c@lwn.net> In-Reply-To: <20201110174749.32068-1-yashsri421@gmail.com> References: <20201110174749.32068-1-yashsri421@gmail.com> Organization: LWN.net MIME-Version: 1.0 Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, joe@perches.com, linux-kernel-mentees@lists.linuxfoundation.org, sir@cmpwn.com Subject: Re: [Linux-kernel-mentees] [PATCH v3] Documentation: include sign off for reverts X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Tue, 10 Nov 2020 23:17:49 +0530 Aditya Srivastava wrote: > Currently, we do not have any documentation on commit reverts regarding > the requirement of Signed-off-by tag for it. This may be misleading to > the users. > > Evaluating MISSING_SIGN_OFF checkpatch warnings on v4.13..v5.8 showed > that 4 out of 11 cases missing a sign-off are revert commits. > > Add documentation regarding the same to document the community > consensus and let readers know. > > Signed-off-by: Aditya Srivastava > --- > Documentation/process/submitting-patches.rst | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst > index 83d9a82055a7..fb8261a4be30 100644 > --- a/Documentation/process/submitting-patches.rst > +++ b/Documentation/process/submitting-patches.rst > @@ -404,6 +404,8 @@ then you just add a line saying:: > > using your real name (sorry, no pseudonyms or anonymous contributions.) > This will be done for you automatically if you use ``git commit -s``. > +Reverts should also include "Signed-off-by". ``git revert -s`` does that > +for you. Applied, thanks. jon _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees