From: Nigel Christian Date: Sat, 14 Nov 2020 05:55:40 +0000 Subject: Re: [PATCH] memory: tegra20-emc: remove redundant error message Message-Id: <20201114055540.GA5516@fedora-project> List-Id: References: <20201114051219.GA4746@fedora-project> <1ab114f2-b63e-464d-2022-6571fbf02511@gmail.com> In-Reply-To: <1ab114f2-b63e-464d-2022-6571fbf02511@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Dmitry Osipenko Cc: krzk@kernel.org, thierry.reding@gmail.com, jonathanh@nvidia.com, kernel-janitors@vger.kernel.org, linux-tegra@vger.kernel.org On Sat, Nov 14, 2020 at 08:33:47AM +0300, Dmitry Osipenko wrote: > 14.11.2020 08:12, Nigel Christian пишет: > > There is no need for dev_err() since irq already prints an error. > > Eliminate unnecessary curly braces for single statement block. > > > > Signed-off-by: Nigel Christian > > --- > > drivers/memory/tegra/tegra20-emc.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c > > index 5e10aa97809f..181a360d7d6b 100644 > > --- a/drivers/memory/tegra/tegra20-emc.c > > +++ b/drivers/memory/tegra/tegra20-emc.c > > @@ -959,10 +959,8 @@ static int tegra_emc_probe(struct platform_device *pdev) > > int irq, err; > > > > irq = platform_get_irq(pdev, 0); > > - if (irq < 0) { > > - dev_err(&pdev->dev, "please update your device tree\n"); > > + if (irq < 0) > > return irq; > > - } > > > > emc = devm_kzalloc(&pdev->dev, sizeof(*emc), GFP_KERNEL); > > if (!emc) > > > > This message has a special purpose, it shouldn't be removed. Please > always check what auto-generated patches actually do. Apologies, understood. Thank you for your time.