Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFC28C5519F for ; Sat, 14 Nov 2020 16:36:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6CAC20797 for ; Sat, 14 Nov 2020 16:36:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726884AbgKNQgh (ORCPT ); Sat, 14 Nov 2020 11:36:37 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:55238 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726265AbgKNQgh (ORCPT ); Sat, 14 Nov 2020 11:36:37 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kdyXP-0072tB-Fs; Sat, 14 Nov 2020 17:36:31 +0100 Date: Sat, 14 Nov 2020 17:36:31 +0100 From: Andrew Lunn To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: Gregory CLEMENT , arm@kernel.org, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Jason Cooper , Andreas =?iso-8859-1?Q?F=E4rber?= , Rob Herring , devicetree@vger.kernel.org Subject: Re: [PATCH mvebu-dt 4/6] ARM: dts: turris-omnia: add SFP node Message-ID: <20201114163631.GC1480543@lunn.ch> References: <20201114160409.19670-1-kabel@kernel.org> <20201114160409.19670-5-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201114160409.19670-5-kabel@kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, Nov 14, 2020 at 05:04:07PM +0100, Marek Behún wrote: > Turris Omnia has a SFP cage that, together with WAN PHY is connected to > eth2 SerDes via a SerDes multiplexor. Describe the SFP cage, but leave > it disabled. Until phylink has support for such multiplexor we will > leave it to U-Boot to enable SFP and disable WAN PHY at boot time > depending on whether a SFP module is present. > > Signed-off-by: Marek Behún > Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia") Same comment for the fixes, especially since this is disabled by default. Reviewed-by: Andrew Lunn Andrew