Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id EEFE46E509 for ; Thu, 19 Nov 2020 13:29:23 +0000 (UTC) Date: Thu, 19 Nov 2020 14:29:19 +0100 From: Katarzyna Dec Message-ID: <20201119132919.GW6508@kdec5-desk.ger.corp.intel.com> References: <20201105044315.24370-1-sai.gowtham.ch@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201105044315.24370-1-sai.gowtham.ch@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t]i915/gem_linear_blits: Added description to the subtest List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: sai.gowtham.ch@intel.com Cc: igt-dev@lists.freedesktop.org List-ID: On Thu, Nov 05, 2020 at 10:13:15AM +0530, sai.gowtham.ch@intel.com wrote: > From: sai gowtham > > Added description to basic subtest. > > Cc: Melkaveri Arjun > Signed-off-by: sai gowtham > --- > tests/i915/gem_linear_blits.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/i915/gem_linear_blits.c b/tests/i915/gem_linear_blits.c > index cae42d52..9b9d8011 100644 > --- a/tests/i915/gem_linear_blits.c > +++ b/tests/i915/gem_linear_blits.c > @@ -215,6 +215,8 @@ igt_main > count = (count + ncpus - 1) / ncpus; > } > > + igt_describe("This test is to check if the basics work when doing many blits," > + " with a working set larger than the aperture size"); In my opinion copy-paste of description from Top to here is waste of time. Gives no additional information. It should be more like: igt_describe("Excercise 2 buffer objects check if driver will reaarange them."); buffers."); > igt_subtest("basic") > run_test(fd, 2); While you are already checking this binary, please do the same for other cases. Hint - investigate file changes wih git-blame. Kasia > > -- > 2.28.0 > > _______________________________________________ > igt-dev mailing list > igt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/igt-dev _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev