Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F887C388F9 for ; Thu, 19 Nov 2020 19:04:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB5B5221FC for ; Thu, 19 Nov 2020 19:04:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MVkSXEzq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="vGde4tED" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB5B5221FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=v6Vh1t8lQzT4oa4KJtZEVDohIttptBfenow4d2a+EQQ=; b=MVkSXEzqDwFbvn/PODvfH8URb mb5RkqGQ6t5DO67rh01G3/3PkH0UaSCuIDRltkmujO0ogZhZ7QH3CzHb4jn/jnvXu2hkw5UsC07R/ LgTySeYGEOSozjH1DnldeeBtYYkCvQ8egXOj/CgXUEn9iNSDSHJEtrxydWaRcPhbkrDllxNy9hlqs qLj2G4GI9643XEqAFp6NS2k7/jJDDrNMdNhtEUQw0a1MftiFNF5uiZC4NTLlm1mJLorWrDCiY4Zl6 /0WE7AfeHdb3T9/eW+hlezhnsnEr2XhbloUsHdeyimiRg/FOdjjDz6iHPg8swQ5rDv/LKL11jDl0l qnr3/4CMg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfpCv-000345-Im; Thu, 19 Nov 2020 19:03:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfpCs-00033P-DZ for linux-arm-kernel@lists.infradead.org; Thu, 19 Nov 2020 19:02:59 +0000 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DA26C2469D; Thu, 19 Nov 2020 19:02:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605812576; bh=Ox4d02EgXMlbyIysDYoU8CWpk+LdkxLydAfnhZ39Avo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vGde4tED+9gioqSEwD3r4906ot2xADiNjCn9f5tmF3k9fXLon+XnoBWwNlbk4q45F 7PTYvW5kH7HW7sfE43nXHlWTSN5wNnjcBRGJLDzPyM/Ss+C93cEQsIhEiNTMz9atA9 HdKb5YmDqe3wMgUaTPXjburRnLoU8RwejshVMWb0= Date: Thu, 19 Nov 2020 19:02:35 +0000 From: Mark Brown To: Dave Martin Subject: Re: [PATCH v5 1/2] arm64/sve: Don't disable SVE on syscalls return Message-ID: <20201119190235.GK5554@sirena.org.uk> References: <20201106193553.22946-2-broonie@kernel.org> <20201113184855.GF3212@gaia> <20201113201328.GG4828@sirena.org.uk> <20201116175938.GA6882@arm.com> <20201116194551.GG4739@sirena.org.uk> <20201117181618.GC6882@arm.com> <20201117230338.GI5142@sirena.org.uk> <20201118125155.GE6882@arm.com> <20201118175201.GE4827@sirena.org.uk> <20201119182748.GN6882@arm.com> MIME-Version: 1.0 In-Reply-To: <20201119182748.GN6882@arm.com> X-Cookie: Chocolate chip. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_140258_647174_34AD8B4D X-CRM114-Status: GOOD ( 26.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , Catalin Marinas , Zhang Lei , Julien Grall , Will Deacon , linux-arm-kernel@lists.infradead.org, Daniel Kiss Content-Type: multipart/mixed; boundary="===============2040445235290300955==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2040445235290300955== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cN0A5YokcrYPGsSB" Content-Disposition: inline --cN0A5YokcrYPGsSB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 19, 2020 at 06:27:50PM +0000, Dave Martin wrote: > On Wed, Nov 18, 2020 at 05:52:01PM +0000, Mark Brown wrote: > > On Wed, Nov 18, 2020 at 12:51:56PM +0000, Dave Martin wrote: > > > I think I missed this point. It doesn't sound quite right to me: how > > > will we ever turn SVE persistently off for a task? > > As mentioned in the cover letter (which I inherited from Julien, it's > > been this way since v1) we don't currently, the proposal mentioned in > > the cover letter is to turn it off after some number of syscalls. > I think there are two levels of this: > 1) Basically the same behaviour as today, but optimising the fast path > of a non-scheduling syscall to avoid dumping and reloading the regs, > while not making other things worse (i.e., we still want SVE to get > turned off when appropriate). > 2) Introducing some logic to try to make an educated guess about whether > SVE should be on or off. > It wasn't clear that (2) would really be any better in practice than > static logic -- after all, other arches have adopted such a thing and > then subsequently dumped it -- but I don't have a strong argument > against it. > I guess I'd prefer to see this arbitrary (if straightforward) policy as > a second patch, separate from the shovelwork in (1). Hrm, right. I guess part of it here is that both behaviours are equally arbatrary and the leaving it on behaviour just falls out of the rest of the change in the same way that the existing behaviour just falls out of the current implementation. I suspect given the limited availability of SVE hardware at present and some educated guess as to what it might be used for that current systems will struggle to notice either way but that'll change as the feature makes it's way into a wider range of systems. I think the clearest thing will be to leave this initial change with similar behaviour to what it currently has and add another patch with a policy for turning SVE off to the series, that'll separate things in the review if nothing else. --cN0A5YokcrYPGsSB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl+2wUoACgkQJNaLcl1U h9AF2Af/aObN/ubcuhEguupVWPncDe/9wDMQV2p4hH8kVvZcaIC1y0bF7bUB5FxX IcphLxz84fDECk/7JzJ3IfHn5lwVUoz+qDNskneVArCo3b6jnzhze204xsRoGOH9 quFGdJGeCr/ed+KgOIrVy/+ADktn1xUoyuehTR2PZMd2xrdmcjSR/L+Wo/wq7Ue+ aVcmopyiYvk11rH7EQzdBmpLq4wzbIojxFnagauj+G3QQqYXT6SUKdPo/kuRMgGc PZPOBrZh+NTlbHQeVtByWxNhfbMG3b3kd16UyYnEVehSDAqnh+Gw7NCjjrOYPOn8 V9zGHwTu4qx7x9Js4ZDIhSa4FqWJEA== =q3Vh -----END PGP SIGNATURE----- --cN0A5YokcrYPGsSB-- --===============2040445235290300955== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2040445235290300955==--